Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(645)

#23722: During metaclass.__init__, super() of the constructed class does not work

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by martin.teichmann
Modified:
10 months, 2 weeks ago
Reviewers:
storchaka+cpython, ncoghlan
CC:
Nick Coghlan, larry, ned.deily, devnull_psf.upfronthosting.co.za, eric.snow, storchaka, tecki, Tim.Graham, ebarry
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 3

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 26

Patch Set 7 #

Total comments: 5

Patch Set 8 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/reference/datamodel.rst View 1 2 3 4 5 6 7 1 chunk +21 lines, -0 lines 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
Lib/importlib/_bootstrap_external.py View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
Lib/test/test_super.py View 1 2 3 4 5 6 7 6 chunks +103 lines, -22 lines 0 comments Download
Objects/typeobject.c View 1 2 3 4 5 6 7 1 chunk +9 lines, -2 lines 0 comments Download
Python/bltinmodule.c View 1 2 3 4 5 6 7 2 chunks +35 lines, -5 lines 2 comments Download
Python/compile.c View 1 2 3 4 5 6 7 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4
tecki
This is a pretty detailed description on what is going on in my patch. http://bugs.python.org/review/23722/diff/17899/Objects/typeobject.c ...
1 year, 3 months ago #1
storchaka
http://bugs.python.org/review/23722/diff/19348/Lib/test/test_super.py File Lib/test/test_super.py (right): http://bugs.python.org/review/23722/diff/19348/Lib/test/test_super.py#newcode223 Lib/test/test_super.py:223: class WithClassRef(metaclass=Meta): Shouldn't namespace_snapshot be reset? http://bugs.python.org/review/23722/diff/19348/Lib/test/test_super.py#newcode245 Lib/test/test_super.py:245: with ...
10 months, 2 weeks ago #2
Nick Coghlan
New patch coming shortly that addresses Serhiy's comments. http://bugs.python.org/review/23722/diff/19348/Lib/test/test_super.py File Lib/test/test_super.py (right): http://bugs.python.org/review/23722/diff/19348/Lib/test/test_super.py#newcode3 Lib/test/test_super.py:3: import ...
10 months, 2 weeks ago #3
storchaka
10 months, 2 weeks ago #4
https://bugs.python.org/review/23722/diff/19353/Python/bltinmodule.c
File Python/bltinmodule.c (right):

https://bugs.python.org/review/23722/diff/19353/Python/bltinmodule.c#newcode179
Python/bltinmodule.c:179: /* TODO: In 3.7, the deprecation warning becomes a
RuntimeError
A dot is needed since the next line is a different sentence.

https://bugs.python.org/review/23722/diff/19353/Python/bltinmodule.c#newcode191
Python/bltinmodule.c:191: "__class__ set to %.200R defining %.200R as %.200R.";
What about the ending dot? It usually is not used in one-sentence error
messages.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7