Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170028)

#23684: urlparse() documentation does not account for default scheme

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by vadmium+py
Modified:
4 years, 5 months ago
Reviewers:
berker.peksag
CC:
docs_python.org, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, demian
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/urllib.parse.rst View 3 chunks +9 lines, -7 lines 2 comments Download
Lib/test/test_urlparse.py View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 2
berkerpeksag
The patch looks good to me. You don't need to send another patch. I can ...
4 years, 5 months ago #1
Martin Panter
4 years, 5 months ago #2
http://bugs.python.org/review/23684/diff/14992/Doc/library/urllib.parse.rst
File Doc/library/urllib.parse.rst (right):

http://bugs.python.org/review/23684/diff/14992/Doc/library/urllib.parse.rst#n...
Doc/library/urllib.parse.rst:95: | :attr:`scheme`   | 0     | URL scheme
specifier     | *scheme* argument    |
On 2015/06/22 00:01:42, berkerpeksag wrote:
> "argument" looks incorrect to me. Can this be "value of *scheme*", "*scheme*
> parameter" or something else?

Yes “*scheme* parameter” would be good. Originally I though “argument” would be
more correct, but I agree it feels strange when we are not talking about a
concrete value.

Demian suggested “value of *scheme*”, but I though this might sound like the
attribute “scheme” defaults to itself.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+