Issue 23684: urlparse() documentation does not account for default scheme

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#23684: urlparse() documentation does not account for default scheme

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 6 months ago by vadmium+py

Modified:
4 years, 5 months ago

Reviewers:
berker.peksag

CC:
docs_python.org, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, demian

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 4 years, 6 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Doc/library/urllib.parse.rst	View		3 chunks	+9 lines, -7 lines	2 comments	Download
		Lib/test/test_urlparse.py	View		1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Martin Panter

4 years, 5 months ago #2

http://bugs.python.org/review/23684/diff/14992/Doc/library/urllib.parse.rst
File Doc/library/urllib.parse.rst (right):

http://bugs.python.org/review/23684/diff/14992/Doc/library/urllib.parse.rst#n...
Doc/library/urllib.parse.rst:95: | :attr:`scheme`   | 0     | URL scheme
specifier     | *scheme* argument    |
On 2015/06/22 00:01:42, berkerpeksag wrote:
> "argument" looks incorrect to me. Can this be "value of *scheme*", "*scheme*
> parameter" or something else?

Yes “*scheme* parameter” would be good. Originally I though “argument” would be
more correct, but I agree it feels strange when we are not talking about a
concrete value.

Demian suggested “value of *scheme*”, but I though this might sound like the
attribute “scheme” defaults to itself.

Expand All Messages | Collapse All Messages