Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

#23671: string.Template doesn't work with the self keyword argument

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by storchaka+cpython
Modified:
4 years, 4 months ago
Reviewers:
p.f.moore, demianbrecht
CC:
Georg, terry.reedy, eric.araujo, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/string.rst View 1 1 chunk +4 lines, -0 lines 0 comments Download
Doc/whatsnew/3.5.rst View 1 1 chunk +4 lines, -0 lines 0 comments Download
Lib/string.py View 1 3 chunks +26 lines, -3 lines 0 comments Download
Lib/test/test_pep292.py View 1 3 chunks +7 lines, -0 lines 0 comments Download
Lib/test/test_string.py View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4
pmoore
https://bugs.python.org/review/23671/diff/14199/Lib/string.py File Lib/string.py (right): https://bugs.python.org/review/23671/diff/14199/Lib/string.py#newcode101 Lib/string.py:101: self, *args = args Maybe worth adding a comment ...
4 years, 4 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/23671/diff/14199/Lib/string.py File Lib/string.py (right): https://bugs.python.org/review/23671/diff/14199/Lib/string.py#newcode101 Lib/string.py:101: self, *args = args On 2015/03/19 12:01:17, pmoore wrote: ...
4 years, 4 months ago #2
demian
https://bugs.python.org/review/23671/diff/14199/Lib/string.py File Lib/string.py (right): https://bugs.python.org/review/23671/diff/14199/Lib/string.py#newcode101 Lib/string.py:101: self, *args = args On 2015/03/19 12:36:56, storchaka wrote: ...
4 years, 4 months ago #3
demian
4 years, 4 months ago #4
https://bugs.python.org/review/23671/diff/14199/Lib/string.py
File Lib/string.py (right):

https://bugs.python.org/review/23671/diff/14199/Lib/string.py#newcode101
Lib/string.py:101: self, *args = args

> Perhaps just mention that it allows for "self" to be passed in as a kwarg?

Or more generally that it allows for kwargs with the same names as position
arguments.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+