Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65358)

#23566: RFE: faulthandler.register() should support file descriptors

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by vstinner
Modified:
4 years, 3 months ago
Reviewers:
weiwu
CC:
haypo, devnull_psf.upfronthosting.co.za, kilowu
Visibility:
Public.

Patch Set 1 #

Total comments: 11

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Patch Set 4 #

Total comments: 7

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_faulthandler.py View 1 2 3 4 19 chunks +122 lines, -121 lines 0 comments Download

Messages

Total messages: 5
victor.stinner_gmail.com
First review. http://bugs.python.org/review/23566/diff/14142/Lib/test/test_faulthandler.py File Lib/test/test_faulthandler.py (right): http://bugs.python.org/review/23566/diff/14142/Lib/test/test_faulthandler.py#newcode474 Lib/test/test_faulthandler.py:474: else: You should use use_fd here, not ...
4 years, 3 months ago #1
victor.stinner_gmail.com
http://bugs.python.org/review/23566/diff/14156/Doc/library/faulthandler.rst File Doc/library/faulthandler.rst (right): http://bugs.python.org/review/23566/diff/14156/Doc/library/faulthandler.rst#newcode63 Doc/library/faulthandler.rst:63: thread. Hum, I suggest to add a new paragraph ...
4 years, 3 months ago #2
victor.stinner_gmail.com
http://bugs.python.org/review/23566/diff/14188/Lib/test/test_faulthandler.py File Lib/test/test_faulthandler.py (right): http://bugs.python.org/review/23566/diff/14188/Lib/test/test_faulthandler.py#newcode225 Lib/test/test_faulthandler.py:225: with temporary_filename() as filename: You can try to move ...
4 years, 3 months ago #3
kilowu
http://bugs.python.org/review/23566/diff/14188/Lib/test/test_faulthandler.py File Lib/test/test_faulthandler.py (right): http://bugs.python.org/review/23566/diff/14188/Lib/test/test_faulthandler.py#newcode225 Lib/test/test_faulthandler.py:225: with temporary_filename() as filename: On 2015/03/16 11:30:04, haypo wrote: ...
4 years, 3 months ago #4
victor.stinner_gmail.com
4 years, 3 months ago #5
http://bugs.python.org/review/23566/diff/14188/Lib/test/test_faulthandler.py
File Lib/test/test_faulthandler.py (right):

http://bugs.python.org/review/23566/diff/14188/Lib/test/test_faulthandler.py#...
Lib/test/test_faulthandler.py:225: with temporary_filename() as filename:
check_fatal_error() can generate the code, as done for other tests.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+