Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47258)

#23539: Content-length not set for HTTP methods expecting body when body is None

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by demianbrecht
Modified:
4 years, 6 months ago
Reviewers:
jim, rdmurray
CC:
orsenthil, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, demian, jimr
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Total comments: 1

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/httplib.rst View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
Lib/httplib.py View 1 2 3 4 3 chunks +24 lines, -13 lines 0 comments Download
Lib/test/test_httplib.py View 1 2 3 4 2 chunks +53 lines, -14 lines 0 comments Download

Messages

Total messages: 6
demian
http://bugs.python.org/review/23539/diff/14042/Lib/httplib.py File Lib/httplib.py (right): http://bugs.python.org/review/23539/diff/14042/Lib/httplib.py#newcode1016 Lib/httplib.py:1016: method.upper() in ('OPTIONS', 'PATCH', 'POST', 'PUT') Super minor nitpick: ...
4 years, 6 months ago #1
jimr
Agreed on all points. Should we drop OPTIONS from the method list though?
4 years, 6 months ago #2
demian
http://bugs.python.org/review/23539/diff/14047/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/23539/diff/14047/Lib/test/test_httplib.py#newcode158 Lib/test/test_httplib.py:158: # for methods that don't expect a body. I'd ...
4 years, 6 months ago #3
r.david.murray
Some small doc and style comments. http://bugs.python.org/review/23539/diff/14047/Doc/library/httplib.rst File Doc/library/httplib.rst (right): http://bugs.python.org/review/23539/diff/14047/Doc/library/httplib.rst#newcode443 Doc/library/httplib.rst:443: automatically for all ...
4 years, 6 months ago #4
jimr
On 2015/03/04 03:34:56, r.david.murray wrote: > Some small doc and style comments. > > http://bugs.python.org/review/23539/diff/14047/Doc/library/httplib.rst ...
4 years, 6 months ago #5
demian
4 years, 6 months ago #6
http://bugs.python.org/review/23539/diff/14256/Lib/http/client.py
File Lib/http/client.py (right):

http://bugs.python.org/review/23539/diff/14256/Lib/http/client.py#newcode1046
Lib/http/client.py:1046: thelen = 0
Super minor: It would make sense that this assignment should be consistent with
the rest, which are currently strings. I'd probably change the others to ints to
allow for a single encoding step in putheader() rather than what we currently
have (int > string > bytes).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+