Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69169)

#23488: Random objects twice as big as necessary on 64-bit builds

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by raymond.hettinger
Modified:
4 years, 2 months ago
Reviewers:
victor.stinner, storchaka, pitrou
CC:
rhettinger, mark.dickinson, AntoinePitrou, haypo, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/_randommodule.c View 1 11 chunks +66 lines, -69 lines 7 comments Download

Messages

Total messages: 6
victor.stinner_gmail.com
https://bugs.python.org/review/23488/diff/13996/Modules/_randommodule.c File Modules/_randommodule.c (right): https://bugs.python.org/review/23488/diff/13996/Modules/_randommodule.c#newcode265 Modules/_randommodule.c:265: #if !PY_LITTLE_ENDIAN Use maybe "#if PY_BIG_ENDIAN", it's more explicit ...
4 years, 2 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/23488/diff/13996/Modules/_randommodule.c File Modules/_randommodule.c (right): https://bugs.python.org/review/23488/diff/13996/Modules/_randommodule.c#newcode265 Modules/_randommodule.c:265: #if !PY_LITTLE_ENDIAN On 2015/03/27 01:07:02, haypo wrote: > Use ...
4 years, 2 months ago #2
victor.stinner_gmail.com
http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c File Modules/_randommodule.c (right): http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c#newcode332 Modules/_randommodule.c:332: self->state[i] = (PY_UINT32_T)element; You should keep the comment. /* ...
4 years, 2 months ago #3
AntoinePitrou
http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c File Modules/_randommodule.c (right): http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c#newcode332 Modules/_randommodule.c:332: self->state[i] = (PY_UINT32_T)element; On 2015/03/27 10:57:33, haypo wrote: > ...
4 years, 2 months ago #4
storchaka_gmail.com
http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c File Modules/_randommodule.c (right): http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c#newcode332 Modules/_randommodule.c:332: self->state[i] = (PY_UINT32_T)element; On 2015/03/27 10:57:33, haypo wrote: > ...
4 years, 2 months ago #5
AntoinePitrou
4 years, 2 months ago #6
http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c
File Modules/_randommodule.c (right):

http://bugs.python.org/review/23488/diff/14351/Modules/_randommodule.c#newcod...
Modules/_randommodule.c:371: /* Fill-out whole words, byte-by-byte to avoid
endianness issues */
On 2015/03/27 13:41:54, storchaka wrote:
> On 2015/03/27 12:50:05, AntoinePitrou wrote:
> > The comment is obsolete.
> 
> What about:
> 
> /* Fill-out bits of long integer, by 32-bit words, from least significant to
> most significant */
> 
> ?

Sounds good to me.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+