Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76904)

#23439: Fixed http.client.__all__ and added a test

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by vadmium+py
Modified:
4 years, 5 months ago
Reviewers:
demianbrecht
CC:
devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, demian
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/http.client.rst View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
Lib/http/client.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
Lib/test/test_httplib.py View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4
demian
http://bugs.python.org/review/23439/diff/13903/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/23439/diff/13903/Lib/test/test_httplib.py#newcode199 Lib/test/test_httplib.py:199: if name == "LineTooLong": # Undocumented object I'd argue ...
4 years, 6 months ago #1
Martin Panter
https://bugs.python.org/review/23439/diff/13903/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): https://bugs.python.org/review/23439/diff/13903/Lib/test/test_httplib.py#newcode204 Lib/test/test_httplib.py:204: self.assertCountEqual(client.__all__, expected) On 2015/02/13 02:14:00, demian wrote: > Rather ...
4 years, 6 months ago #2
demian
http://bugs.python.org/review/23439/diff/13903/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/23439/diff/13903/Lib/test/test_httplib.py#newcode204 Lib/test/test_httplib.py:204: self.assertCountEqual(client.__all__, expected) On 2015/02/13 02:26:10, vadmium wrote: > On ...
4 years, 6 months ago #3
demian
4 years, 6 months ago #4
http://bugs.python.org/review/23439/diff/13939/Lib/test/test_httplib.py
File Lib/test/test_httplib.py (right):

http://bugs.python.org/review/23439/diff/13939/Lib/test/test_httplib.py#newco...
Lib/test/test_httplib.py:916: expected = ["responses"]  # White-list documented
dict() object
Super minor and far from merge-blocking, but why not use a set for this as well
and use .add() rather than .append() below?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+