Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(486)

#23430: socketserver.BaseServer.handle_error() should not catch exiting exceptions

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by vadmium+py
Modified:
1 year, 8 months ago
Reviewers:
storchaka, berker.peksag
CC:
AntoinePitrou, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 9

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 3

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/socketserver.rst View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 3 4 5 1 chunk +10 lines, -1 line 0 comments Download
Lib/socketserver.py View 1 2 3 4 5 5 chunks +18 lines, -13 lines 0 comments Download
Lib/test/test_socketserver.py View 1 2 3 4 5 2 chunks +92 lines, -0 lines 0 comments Download
Misc/NEWS View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
storchaka_gmail.com
https://bugs.python.org/review/23430/diff/13943/Lib/socketserver.py File Lib/socketserver.py (right): https://bugs.python.org/review/23430/diff/13943/Lib/socketserver.py#newcode610 Lib/socketserver.py:610: except BaseException as exc: You have used two different ...
2 years, 7 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/23430/diff/13943/Lib/test/test_socketserver.py File Lib/test/test_socketserver.py (right): https://bugs.python.org/review/23430/diff/13943/Lib/test/test_socketserver.py#newcode286 Lib/test/test_socketserver.py:286: class BadHandler(socketserver.BaseRequestHandler): Looks as these classes don't use any ...
2 years, 7 months ago #2
Martin Panter
https://bugs.python.org/review/23430/diff/13943/Lib/test/test_socketserver.py File Lib/test/test_socketserver.py (right): https://bugs.python.org/review/23430/diff/13943/Lib/test/test_socketserver.py#newcode314 Lib/test/test_socketserver.py:314: server._handle_request_noblock() On 2015/03/21 10:20:13, storchaka wrote: > _handle_request_noblock is ...
2 years, 6 months ago #3
berkerpeksag
1 year, 8 months ago #4
http://bugs.python.org/review/23430/diff/16573/Doc/whatsnew/3.6.rst
File Doc/whatsnew/3.6.rst (right):

http://bugs.python.org/review/23430/diff/16573/Doc/whatsnew/3.6.rst#newcode316
Doc/whatsnew/3.6.rst:316: the exception will stop a single-threaded server. See
:issue:`23430`.
See :issue:`23430`. -> (Contributed by Martin Panter in :issue:`23430`.)

http://bugs.python.org/review/23430/diff/16573/Lib/test/test_socketserver.py
File Lib/test/test_socketserver.py (right):

http://bugs.python.org/review/23430/diff/16573/Lib/test/test_socketserver.py#...
Lib/test/test_socketserver.py:326: 
Rest of the file uses two new lines between classes.

http://bugs.python.org/review/23430/diff/16573/Lib/test/test_socketserver.py#...
Lib/test/test_socketserver.py:356: return super().__init__(*pos, **kw)
Looks like the return statement can be removed.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7