Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25660)

#23421: tarfile module does not correctly choose compression algorithms

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by wdv4758h
Modified:
4 years, 7 months ago
Reviewers:
storchaka
CC:
devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, chiu-hsiang.hsu
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_tarfile.py View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 1
storchaka_gmail.com
4 years, 7 months ago #1
https://bugs.python.org/review/23421/diff/13880/Lib/test/test_tarfile.py
File Lib/test/test_tarfile.py (right):

https://bugs.python.org/review/23421/diff/13880/Lib/test/test_tarfile.py#newc...
Lib/test/test_tarfile.py:2022: for filetype in (TarTest, GzipTest, Bz2Test,
LzmaTest):
Uncompressed tar files already tested in other tests, so TarTest is not needed
here. For compressed tar files the file name can be calculated as tmpname + '.'
+ suffix.

https://bugs.python.org/review/23421/diff/13880/Lib/test/test_tarfile.py#newc...
Lib/test/test_tarfile.py:2023: for opt in '-c', '--create':
The long option already tested in other test. This test would be simpler if use
only '-c'.

https://bugs.python.org/review/23421/diff/13880/Lib/test/test_tarfile.py#newc...
Lib/test/test_tarfile.py:2025: out = self.tarfilecmd(opt, filetype.clitarname,
*files)
Compression can be not available if required module (gzip, bz2 or lzma) is not
available.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+