Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96751)

#23399: venv should create relative symlinks where possible

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by barry
Modified:
4 years ago
Reviewers:
storchaka
CC:
barry, Vinay Sajip, devnull_psf.upfronthosting.co.za, dstufft
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/venv/__init__.py View 5 chunks +7 lines, -6 lines 2 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/23399/diff/13849/Lib/venv/__init__.py File Lib/venv/__init__.py (right): http://bugs.python.org/review/23399/diff/13849/Lib/venv/__init__.py#newcode189 Lib/venv/__init__.py:189: os.symlink(os.path.basename(src), dst) This works only when src and dst ...
4 years ago #1
barry
4 years ago #2
Thanks!  I'll add the assert.

http://bugs.python.org/review/23399/diff/13849/Lib/venv/__init__.py
File Lib/venv/__init__.py (right):

http://bugs.python.org/review/23399/diff/13849/Lib/venv/__init__.py#newcode189
Lib/venv/__init__.py:189: os.symlink(os.path.basename(src), dst)
On 2015/02/06 10:19:23, storchaka wrote:
> This works only when src and dst are in the same directory (always true for
> now). May be add "assert os.path.dirname(src) == os.path.dirname(dst)"?

Seems reasonable.  +1
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+