Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

#23290: Faster set copying

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by storchaka+cpython
Modified:
4 years, 10 months ago
Reviewers:
victor.stinner, jimjjewett
CC:
rhettinger, AntoinePitrou, haypo, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Total comments: 2

Patch Set 5 #

Patch Set 6 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/setobject.c View 1 2 3 4 5 2 chunks +37 lines, -10 lines 1 comment Download

Messages

Total messages: 5
victor.stinner_gmail.com
https://bugs.python.org/review/23290/diff/13747/Objects/setobject.c File Objects/setobject.c (right): https://bugs.python.org/review/23290/diff/13747/Objects/setobject.c#newcode565 Objects/setobject.c:565: clear = so->fill == 0; Is it possible to ...
5 years ago #1
storchaka_gmail.com
https://bugs.python.org/review/23290/diff/13747/Objects/setobject.c File Objects/setobject.c (right): https://bugs.python.org/review/23290/diff/13747/Objects/setobject.c#newcode565 Objects/setobject.c:565: clear = so->fill == 0; On 2015/03/27 01:13:59, haypo ...
5 years ago #2
Jim.J.Jewett
https://bugs.python.org/review/23290/diff/14350/Objects/setobject.c File Objects/setobject.c (right): https://bugs.python.org/review/23290/diff/14350/Objects/setobject.c#newcode583 Objects/setobject.c:583: if (dump) { If the new table is clear, ...
5 years ago #3
storchaka_gmail.com
https://bugs.python.org/review/23290/diff/14350/Objects/setobject.c File Objects/setobject.c (right): https://bugs.python.org/review/23290/diff/14350/Objects/setobject.c#newcode583 Objects/setobject.c:583: if (dump) { On 2015/03/27 15:26:36, Jim.J.Jewett wrote: > ...
5 years ago #4
storchaka_gmail.com
4 years, 10 months ago #5
http://bugs.python.org/review/23290/diff/14825/Objects/setobject.c
File Objects/setobject.c (right):

http://bugs.python.org/review/23290/diff/14825/Objects/setobject.c#newcode568
Objects/setobject.c:568: setentry *so_entry = so->table, *other_entry =
other->table;
error: ISO C90 forbids mixed declarations and code
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+