Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48311)

#23228: Crashes when tarfile contains a symlink and unpack directory contain it too

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by michael.vogt
Modified:
2 months ago
Reviewers:
barry, vadmium+py
CC:
barry, lars.gustaebel, michael.vogt_gmail.com, SilentGhost, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/tarfile.py View 1 2 3 2 chunks +7 lines, -8 lines 1 comment Download
Lib/test/test_tarfile.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
barry
I added some comments. I'd like to get a second opinion about the fix implementation, ...
4 years, 1 month ago #1
barry
4 years, 1 month ago #2
Martin Panter
2 months ago #3
https://bugs.python.org/review/23228/diff/17198/Lib/tarfile.py
File Lib/tarfile.py (right):

https://bugs.python.org/review/23228/diff/17198/Lib/tarfile.py#newcode2205
Lib/tarfile.py:2205: if getattr(e, "winerror", None) is None:
What about AttributeError and NotImplementedError, which never have a “winerror”
attribute? Perhaps you should add a test for extracting symlinks that runs in
situations where these exceptions occur.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+