Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

#23138: cookiejar parses cookie value as int with empty name-value pair and Expires

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by chris.foo
Modified:
4 years, 10 months ago
Reviewers:
storchaka, demianbrecht
CC:
BreamoreBoy, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, demian, chfoo
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 8

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/http/cookiejar.py View 1 2 3 4 3 chunks +35 lines, -15 lines 0 comments Download
Lib/test/test_http_cookiejar.py View 1 2 3 4 5 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3
storchaka_gmail.com
http://bugs.python.org/review/23138/diff/14037/Lib/http/cookiejar.py File Lib/http/cookiejar.py (right): http://bugs.python.org/review/23138/diff/14037/Lib/http/cookiejar.py#newcode475 Lib/http/cookiejar.py:475: for ii, param in enumerate(re.split(r";\s*", ns_header)): str.split is enough. ...
4 years, 10 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py File Lib/http/cookiejar.py (right): https://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py#newcode486 Lib/http/cookiejar.py:486: if len(key) == 0: if not key It is ...
4 years, 10 months ago #2
demian
4 years, 10 months ago #3
http://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py
File Lib/http/cookiejar.py (right):

http://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py#newcode486
Lib/http/cookiejar.py:486: if len(key) == 0:
On 2015/03/10 08:26:43, storchaka wrote:
> if not key
> 
> It is a little faster.

Done.

http://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py#newcode494
Lib/http/cookiejar.py:494: val = val.strip() if len(sep) > 0 else None
On 2015/03/10 08:26:43, storchaka wrote:
> if sep

Done.

http://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py#newcode503
Lib/http/cookiejar.py:503: val = strip_quotes(val)
On 2015/03/10 08:26:43, storchaka wrote:
> What if val is None?

Good catch. I'm going to run with this and the one below should (for
consistency) should be set to None.

http://bugs.python.org/review/23138/diff/14141/Lib/http/cookiejar.py#newcode507
Lib/http/cookiejar.py:507: val = http2time(strip_quotes(val))  # None if invalid
On 2015/03/10 08:26:43, storchaka wrote:
> And here.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+