Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2588)

#23026: Winreg module doesn't support REG_QWORD, small DWORD doc update

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by markgrandi
Modified:
2 years, 9 months ago
Reviewers:
pcmanticore
CC:
pmoore, tim.golden, devnull_psf.upfronthosting.co.za, Zach Ware, markgrandi, eryksun, steve.dower, hakril
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/winreg.rst View 1 2 chunks +9 lines, -1 line 0 comments Download
PC/winreg.c View 1 5 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 1
Claudiu.Popa
2 years, 9 months ago #1
http://bugs.python.org/review/23026/diff/13388/PC/winreg.c
File PC/winreg.c (right):

http://bugs.python.org/review/23026/diff/13388/PC/winreg.c#newcode1861
PC/winreg.c:1861: ADD_INT(REG_QWORD_LITTLE_ENDIAN);
This needs a test in Lib/test/test_winreg. Test that these attributes exists on
the expected platforms.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7