Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25368)

#23014: Don't have importlib.abc.Loader.create_module() be optional

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by brett
Modified:
4 years, 8 months ago
Reviewers:
berker.peksag, ericsnowcurrently
CC:
brett.cannon, Nick Coghlan, Arfrever, devnull_psf.upfronthosting.co.za, eric.snow, Anthony Sottile
Visibility:
Public.

Patch Set 1 #

Total comments: 17
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/importlib.rst View 4 chunks +14 lines, -10 lines 6 comments Download
Doc/reference/import.rst View 3 chunks +7 lines, -1 line 4 comments Download
Lib/importlib/abc.py View 1 chunk +0 lines, -3 lines 0 comments Download
Lib/importlib/_bootstrap.py View 4 chunks +14 lines, -0 lines 6 comments Download
Lib/test/test_importlib/import_/test_api.py View 1 chunk +4 lines, -0 lines 0 comments Download
Lib/test/test_importlib/import_/test___loader__.py View 1 chunk +3 lines, -0 lines 0 comments Download
Lib/test/test_importlib/test_spec.py View 1 chunk +3 lines, -0 lines 0 comments Download
Lib/test/test_importlib/test_util.py View 1 chunk +9 lines, -3 lines 1 comment Download
Lib/test/test_pkgutil.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
berkerpeksag
http://bugs.python.org/review/23014/diff/13401/Doc/library/importlib.rst File Doc/library/importlib.rst (right): http://bugs.python.org/review/23014/diff/13401/Doc/library/importlib.rst#newcode357 Doc/library/importlib.rst:357: Starting in Python 3.6, this method wil not optional ...
4 years, 9 months ago #1
brett.cannon
I have not applied the changes to my own patch yet and I don't know ...
4 years, 9 months ago #2
eric.snow
LGTM. I have just a couple mostly insignificant comments. http://bugs.python.org/review/23014/diff/13401/Doc/library/importlib.rst File Doc/library/importlib.rst (right): http://bugs.python.org/review/23014/diff/13401/Doc/library/importlib.rst#newcode357 Doc/library/importlib.rst:357: ...
4 years, 9 months ago #3
brett.cannon
http://bugs.python.org/review/23014/diff/13401/Lib/importlib/_bootstrap.py File Lib/importlib/_bootstrap.py (right): http://bugs.python.org/review/23014/diff/13401/Lib/importlib/_bootstrap.py#newcode1305 Lib/importlib/_bootstrap.py:1305: @staticmethod On 2014/12/16 03:42:16, eric.snow wrote: > Out of ...
4 years, 9 months ago #4
brett.cannon
Will submit the patch shortly. http://bugs.python.org/review/23014/diff/13401/Doc/library/importlib.rst File Doc/library/importlib.rst (right): http://bugs.python.org/review/23014/diff/13401/Doc/library/importlib.rst#newcode357 Doc/library/importlib.rst:357: Starting in Python 3.6, ...
4 years, 8 months ago #5
brett.cannon
4 years, 8 months ago #6
Will submit the patch shortly.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+