Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

#22977: Unformatted “Windows Error 0x%X” exception message on Wine

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by vadmium+py
Modified:
4 years, 10 months ago
Reviewers:
storchaka
CC:
haypo, tim.golden, Arfrever, devnull_psf.upfronthosting.co.za, Martin Panter, Zach Ware, storchaka, eryksun, steve.dower
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_exceptions.py View 1 2 2 chunks +9 lines, -1 line 0 comments Download
Python/errors.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
https://bugs.python.org/review/22977/diff/13607/Lib/test/test_exceptions.py File Lib/test/test_exceptions.py (right): https://bugs.python.org/review/22977/diff/13607/Lib/test/test_exceptions.py#newcode254 Lib/test/test_exceptions.py:254: self.skipTest(err) support.get_attribute() can be used.
4 years, 10 months ago #1
storchaka_gmail.com
4 years, 10 months ago #2
https://bugs.python.org/review/22977/diff/13607/Lib/test/test_exceptions.py
File Lib/test/test_exceptions.py (right):

https://bugs.python.org/review/22977/diff/13607/Lib/test/test_exceptions.py#n...
Lib/test/test_exceptions.py:256: self.assertRaisesRegex(OSError, format(code,
"x"),
hex(x)?

https://bugs.python.org/review/22977/diff/13607/Lib/test/test_exceptions.py#n...
Lib/test/test_exceptions.py:256: self.assertRaisesRegex(OSError, format(code,
"x"),
This test is already two-line, so it is better to use context manager form.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+