Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123485)

#22955: Pickling of methodcaller, attrgetter, and itemgetter

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by anntzer.lee
Modified:
4 years, 6 months ago
Reviewers:
zachary.ware
CC:
rhettinger, AntoinePitrou, devnull_psf.upfronthosting.co.za, Zach Ware, storchaka, Antony.Lee, Josh.R, thatneat_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 3

Patch Set 4 #

Patch Set 5 #

Total comments: 2

Patch Set 6 #

Patch Set 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/operator.py View 1 2 3 4 5 6 6 chunks +38 lines, -2 lines 0 comments Download
Lib/test/test_operator.py View 1 2 3 4 5 6 4 chunks +109 lines, -0 lines 0 comments Download
Modules/_operator.c View 1 2 3 4 5 6 11 chunks +270 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Zach Ware
http://bugs.python.org/review/22955/diff/13324/Lib/operator.py File Lib/operator.py (right): http://bugs.python.org/review/22955/diff/13324/Lib/operator.py#newcode317 Lib/operator.py:317: def __reduce__(self): As I mentioned in msg231831, pickling of ...
4 years, 11 months ago #1
Zach Ware
4 years, 11 months ago #2
http://bugs.python.org/review/22955/diff/13328/Lib/operator.py
File Lib/operator.py (right):

http://bugs.python.org/review/22955/diff/13328/Lib/operator.py#newcode253
Lib/operator.py:253: return '{}({})'.format(self.__class__.__name__,
Rather than upload another patch, the second {} should be {!r}.

http://bugs.python.org/review/22955/diff/13328/Lib/operator.py#newcode255
Lib/operator.py:255: attrs = ', '.join(('.'.join(getter._names) for getter in
self._getters))
And each attr should be repr()'d.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+