Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169997)

#22832: Tweak parameter names for fcntl module

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by brett
Modified:
4 years, 9 months ago
Reviewers:
storchaka, vadmium+py, a.v.shkop
CC:
brett.cannon, r.david.murray, docs_python.org, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, ashkop
Visibility:
Public.

Patch Set 1 #

Total comments: 8

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/fcntl.rst View 1 2 6 chunks +32 lines, -32 lines 3 comments Download
Modules/clinic/fcntlmodule.c.h View 1 2 7 chunks +17 lines, -18 lines 0 comments Download
Modules/fcntlmodule.c View 1 2 10 chunks +24 lines, -25 lines 0 comments Download

Messages

Total messages: 5
storchaka_gmail.com
https://bugs.python.org/review/22832/diff/14034/Doc/library/fcntl.rst File Doc/library/fcntl.rst (right): https://bugs.python.org/review/22832/diff/14034/Doc/library/fcntl.rst#newcode37 Doc/library/fcntl.rst:37: header files. The argument *arg* is optional, and defaults ...
4 years, 9 months ago #1
Martin Panter
https://bugs.python.org/review/22832/diff/14056/Modules/fcntlmodule.c File Modules/fcntlmodule.c (right): https://bugs.python.org/review/22832/diff/14056/Modules/fcntlmodule.c#newcode43 Modules/fcntlmodule.c:43: arg: object = NULL I’m not familiar with this ...
4 years, 9 months ago #2
storchaka_gmail.com
https://bugs.python.org/review/22832/diff/14056/Modules/fcntlmodule.c File Modules/fcntlmodule.c (right): https://bugs.python.org/review/22832/diff/14056/Modules/fcntlmodule.c#newcode43 Modules/fcntlmodule.c:43: arg: object = NULL On 2015/03/20 03:24:07, vadmium wrote: ...
4 years, 9 months ago #3
ashkop
http://bugs.python.org/review/22832/diff/14056/Modules/fcntlmodule.c File Modules/fcntlmodule.c (right): http://bugs.python.org/review/22832/diff/14056/Modules/fcntlmodule.c#newcode43 Modules/fcntlmodule.c:43: arg: object = NULL On 2015/03/20 03:24:07, vadmium wrote: ...
4 years, 9 months ago #4
storchaka_gmail.com
4 years, 9 months ago #5
https://bugs.python.org/review/22832/diff/14277/Doc/library/fcntl.rst
File Doc/library/fcntl.rst (right):

https://bugs.python.org/review/22832/diff/14277/Doc/library/fcntl.rst#newcode31
Doc/library/fcntl.rst:31: .. function:: fcntl(fd, cmd[, arg=0])
Brackets are not needed longer.

https://bugs.python.org/review/22832/diff/14277/Doc/library/fcntl.rst#newcode53
Doc/library/fcntl.rst:53: .. function:: ioctl(fd, request[, arg=0[,
mutate_flag=True]])
And here too.

https://bugs.python.org/review/22832/diff/14277/Doc/library/fcntl.rst#newcode108
Doc/library/fcntl.rst:108: .. function:: lockf(fd, cmd, [len=0, [start=0,
[whence=0]]])
And here too.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+