Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

#22829: Add --prompt option to venv

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by lukaszbalcerzak
Modified:
1 year, 11 months ago
Reviewers:
berker.peksag
CC:
Vinay Sajip, Nick Coghlan, devnull_psf.upfronthosting.co.za, berkerpeksag, matrixise, Łukasz.Balcerzak
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 3

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/venv.rst View 1 2 2 chunks +9 lines, -1 line 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
Lib/test/test_venv.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
Lib/venv/__init__.py View 1 2 7 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 1
berkerpeksag
2 years, 6 months ago #1
Could you also add a whatsnew entry to Doc/whatsnew/3.5.rst.

http://bugs.python.org/review/22829/diff/14629/Doc/library/venv.rst
File Doc/library/venv.rst (right):

http://bugs.python.org/review/22829/diff/14629/Doc/library/venv.rst#newcode92
Doc/library/venv.rst:92: prompt=None)
There are already too much parameter for this class. I'd make this keyword-only.

http://bugs.python.org/review/22829/diff/14629/Lib/test/test_venv.py
File Lib/test/test_venv.py (right):

http://bugs.python.org/review/22829/diff/14629/Lib/test/test_venv.py#newcode115
Lib/test/test_venv.py:115: Test prompt option.
The comment can be removed here. The test name is already enough to understand
in my opinion.

http://bugs.python.org/review/22829/diff/14629/Lib/venv/__init__.py
File Lib/venv/__init__.py (right):

http://bugs.python.org/review/22829/diff/14629/Lib/venv/__init__.py#newcode439
Lib/venv/__init__.py:439: parser.add_argument('--prompt', dest='prompt',
You can remove dest='prompt'.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7