Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167653)

#22671: Typo in class io.BufferedIOBase docs

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by gigaplastik
Modified:
4 years, 8 months ago
Reviewers:
vadmium+py, storchaka
CC:
AntoinePitrou, haypo, docs_python.org, berkerpeksag, Martin Panter, storchaka, gigaplastik_gmail.com, chkumar246_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/io.rst View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
Lib/test/test_io.py View 1 2 2 chunks +49 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Martin Panter
https://bugs.python.org/review/22671/diff/13472/Doc/library/io.rst File Doc/library/io.rst (right): https://bugs.python.org/review/22671/diff/13472/Doc/library/io.rst#newcode495 Doc/library/io.rst:495: A default implementation is provided. Just noticed the summary ...
4 years, 11 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py File Lib/test/test_io.py (right): https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode608 Lib/test/test_io.py:608: # Exercise the default RawIOBase.read() and readall() implementations May ...
4 years, 8 months ago #2
Martin Panter
4 years, 8 months ago #3
https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py
File Lib/test/test_io.py (right):

https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode608
Lib/test/test_io.py:608: # Exercise the default RawIOBase.read() and readall()
implementations
On 2015/03/21 19:22:00, storchaka wrote:
> May be create separate test for readall?

Okay

https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode636
Lib/test/test_io.py:636: dict(method="readinto", avail=10, request=5, result=5),
On 2015/03/21 19:22:00, storchaka wrote:
> This is too verbose. Tuples would look cleaner. And testing code with
> test["..."] looks untidy.

Perhaps a matrix of tuples with a comment at the top saying what the columns are
would work.

https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode644
Lib/test/test_io.py:644: )
On 2015/03/21 19:22:00, storchaka wrote:
> Does it make sense to add tests for request=0 or -1?

request=0: yes; request=-1: no, because you can’t have a bytearray -1 bytes long
:)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+