Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(553)

#22635: subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by shadowranger+python
Modified:
1 year, 1 month ago
Reviewers:
victor.stinner
CC:
gregory.p.smith, Nick Coghlan, haypo, christian.heimes, tim.golden, Benjamin Peterson, Arfrever, r.david.murray, docs_python.org, acassaigne, josh.rosenberg
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/subprocess.rst View 1 2 3 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2
haypo
http://bugs.python.org/review/22635/diff/18850/Doc/library/subprocess.rst File Doc/library/subprocess.rst (right): http://bugs.python.org/review/22635/diff/18850/Doc/library/subprocess.rst#newcode1165 Doc/library/subprocess.rst:1165: Return ``(status, output)`` of executing *cmd* in a shell. ...
1 year, 1 month ago #1
haypo
1 year, 1 month ago #2
http://bugs.python.org/review/22635/diff/18852/Doc/library/subprocess.rst
File Doc/library/subprocess.rst (right):

http://bugs.python.org/review/22635/diff/18852/Doc/library/subprocess.rst#new...
Doc/library/subprocess.rst:1173: according to the rules for the C function
:c:func:`wait`.  Example::
Sorry, this is wrong as well. Again, it's no more a status but an exit code. I
suggest to remove this sentence.

http://bugs.python.org/review/22635/diff/18852/Doc/library/subprocess.rst#new...
Doc/library/subprocess.rst:1186: Pay attention the behavior has changed the
function now returns
I would suggest to avoid "Pay attention", we don't use this in the Python doc.

"the behaviour has changed" is redundant: we are already in a "versionchanged"
section.

I suggest to remove "Pay attention the behavior has changed".
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7