Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167606)

#22581: Other mentions of the buffer protocol

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by storchaka+cpython
Modified:
5 years ago
Reviewers:
rdmurray
CC:
Georg, rhettinger, terry.reedy, AntoinePitrou, ezio.melotti, eric.araujo, r.david.murray, flox, cjerdonek, docs_python.org, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/arg.rst View 3 chunks +11 lines, -11 lines 7 comments Download
Doc/c-api/unicode.rst View 1 chunk +1 line, -1 line 0 comments Download
Doc/library/socket.rst View 2 chunks +2 lines, -2 lines 1 comment Download
Include/unicodeobject.h View 1 chunk +1 line, -1 line 0 comments Download
Lib/multiprocessing/connection.py View 1 chunk +1 line, -1 line 0 comments Download
Modules/arraymodule.c View 1 chunk +2 lines, -2 lines 0 comments Download
Modules/socketmodule.c View 2 chunks +3 lines, -3 lines 0 comments Download
Objects/stringlib/join.h View 1 chunk +3 lines, -3 lines 0 comments Download
Objects/unicodeobject.c View 1 chunk +1 line, -2 lines 0 comments Download
Python/getargs.c View 6 chunks +7 lines, -7 lines 0 comments Download
Python/marshal.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
r.david.murray
5 years ago #1
http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst
File Doc/c-api/arg.rst (right):

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode73
Doc/c-api/arg.rst:73: ``s*`` (:class:`str`, :class:`bytes`, :class:`bytearray`
or :term:`bytes-like object`) [Py_buffer]
bytes and bytearray are bytes-like object, so wouldn't it be better to just say
:class:`str` or :term:`bytes-like object`?

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode79
Doc/c-api/arg.rst:79: ``s#`` (:class:`str`, :class:`bytes` or read-only
:term:`bytes-like object`) [const char \*, int or :c:type:`Py_ssize_t`]
again, drop :class:`bytes`?  Or, since 'read-only' is a restriction on
bytes-like object that I don't think is covered in the description of the term,
perhaps it should say "read-only :term:`bytes-like object` such as
:class:`bytes`".

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode90
Doc/c-api/arg.rst:90: ``z*`` (:class:`str`, :class:`bytes`, :class:`bytearray`,
:term:`bytes-like object` or ``None``) [Py_buffer]
as above

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode94
Doc/c-api/arg.rst:94: ``z#`` (:class:`str`, :class:`bytes`, read-only
:term:`bytes-like object` or ``None``) [const char \*, int]
as above

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode98
Doc/c-api/arg.rst:98: ``y`` (:class:`bytes` or read-only :term:`bytes-like
object`) [const char \*]
as above

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode104
Doc/c-api/arg.rst:104: ``y*`` (:class:`bytes`, :class:`bytearray` or
:term:`bytes-like object`) [Py_buffer]
as above

http://bugs.python.org/review/22581/diff/13303/Doc/c-api/arg.rst#newcode109
Doc/c-api/arg.rst:109: ``y#`` (:class:`bytes` or read-only :term:`bytes-like
object`) [const char \*, int]
as above

http://bugs.python.org/review/22581/diff/13303/Doc/library/socket.rst
File Doc/library/socket.rst (right):

http://bugs.python.org/review/22581/diff/13303/Doc/library/socket.rst#newcode...
Doc/library/socket.rst:1126: non-ancillary data as an iterable of bytes-like
objects
missing :term:
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+