Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17303)

#22417: PEP 476: verify HTTPS certificates by default

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by ncoghlan
Modified:
4 years, 6 months ago
Reviewers:
pitrou
CC:
jcea, Nick Coghlan, orsenthil, larry, christian.heimes, Benjamin Peterson, jwilk_jwilk.net, Arfrever, alex, devnull_psf.upfronthosting.co.za, koobs, dstufft, raulcd, clopez_igalia.com
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Patch Set 3 #

Total comments: 3

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/http.client.rst View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
Doc/library/urllib.request.rst View 1 2 3 4 5 6 7 2 chunks +2 lines, -7 lines 0 comments Download
Doc/library/xmlrpc.client.rst View 1 2 3 4 5 6 7 1 chunk +3 lines, -4 lines 0 comments Download
Doc/whatsnew/3.4.rst View 1 2 3 4 5 6 7 1 chunk +29 lines, -0 lines 0 comments Download
Lib/http/client.py View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
Lib/ssl.py View 1 2 3 4 5 6 7 2 chunks +9 lines, -2 lines 0 comments Download
Lib/test/test_httplib.py View 1 2 3 4 5 6 7 4 chunks +40 lines, -9 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 4 5 6 7 1 chunk +4 lines, -3 lines 0 comments Download
Lib/test/test_urllib2_localnet.py View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
AntoinePitrou
http://bugs.python.org/review/22417/diff/12880/Lib/ssl.py File Lib/ssl.py (right): http://bugs.python.org/review/22417/diff/12880/Lib/ssl.py#newcode484 Lib/ssl.py:484: _create_default_https_context = create_default_context Compared to _create_stdlib_context, this changes other ...
4 years, 8 months ago #1
AntoinePitrou
4 years, 6 months ago #2
http://bugs.python.org/review/22417/diff/13167/Doc/library/http.client.rst
File Doc/library/http.client.rst (right):

http://bugs.python.org/review/22417/diff/13167/Doc/library/http.client.rst#ne...
Doc/library/http.client.rst:95: This class now uses
:func:`ssl._create_default_https_context` if no
I think the first sentence can be removed. The private function is an
implementation detail. Or perhaps you want to replace it with a mention of
create_default_context().

http://bugs.python.org/review/22417/diff/13167/Doc/library/urllib.request.rst
File Doc/library/urllib.request.rst (left):

http://bugs.python.org/review/22417/diff/13167/Doc/library/urllib.request.rst...
Doc/library/urllib.request.rst:65: .. warning::
Add a "versionchanged" for the change in behaviour perhaps?

http://bugs.python.org/review/22417/diff/13167/Doc/library/xmlrpc.client.rst
File Doc/library/xmlrpc.client.rst (left):

http://bugs.python.org/review/22417/diff/13167/Doc/library/xmlrpc.client.rst#...
Doc/library/xmlrpc.client.rst:30: .. warning::
"versionchanged" here as well?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+