Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88856)

#22241: strftime/strptime round trip fails even for UTC datetime object

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 12 months ago by 4kir4.1i
Modified:
3 years, 11 months ago
Reviewers:
berker.peksag, alexander.belopolsky
CC:
gvanrossum, brett.cannon, mark.dickinson, sasha, akira, devnull_psf.upfronthosting.co.za, berkerpeksag
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 14

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/datetime.rst View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
Lib/datetime.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
Lib/test/datetimetester.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
Modules/_datetimemodule.c View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
berkerpeksag
http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst File Doc/library/datetime.rst (right): http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst#newcode1737 Doc/library/datetime.rst:1737: will be used as the value returned by the ...
3 years, 11 months ago #1
sasha
http://bugs.python.org/review/22241/diff/15431/Lib/test/datetimetester.py File Lib/test/datetimetester.py (left): http://bugs.python.org/review/22241/diff/15431/Lib/test/datetimetester.py#oldcode260 Lib/test/datetimetester.py:260: def test_tzname(self): On 2015/09/03 12:40:35, berkerpeksag wrote: > Also ...
3 years, 11 months ago #2
sasha
3 years, 11 months ago #3
http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst
File Doc/library/datetime.rst (right):

http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst#newco...
Doc/library/datetime.rst:1737: will be used as the value returned by the
``tzname(dt)`` method.
On 2015/09/03 12:40:35, berkerpeksag wrote:
> I'd change ``tzname(dt)`` with :meth:`timezone.tzname`.

Done.

http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst#newco...
Doc/library/datetime.rst:1751: is constructed.  If ``name`` is not provided in
the constructor, the
On 2015/09/03 12:40:35, berkerpeksag wrote:
> ``name`` -> *name* (since it's part of a class signature)

Done.

http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst#newco...
Doc/library/datetime.rst:1753: ``offset`` as follows.  If ``offset`` is
``timedelta(0)``, the name
On 2015/09/03 12:40:35, berkerpeksag wrote:
> ``offset`` -> *offset*

Done.

http://bugs.python.org/review/22241/diff/15431/Doc/library/datetime.rst#newco...
Doc/library/datetime.rst:1758: .. versionchanged:: 3.6
On 2015/09/03 12:40:35, berkerpeksag wrote:
> We usually add a quick description when we use the versionchanged directive.
> Could you also describe what is changed in 3.6 here?

Done.

http://bugs.python.org/review/22241/diff/15431/Modules/_datetimemodule.c
File Modules/_datetimemodule.c (right):

http://bugs.python.org/review/22241/diff/15431/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:3291: (GET_TD_DAYS(self->offset) == 0 &&
On 2015/09/03 12:40:35, berkerpeksag wrote:
> Indentation should be 4 spaces here.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+