Issue 22184: lrucache should reject maxsize as a function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#22184: lrucache should reject maxsize as a function

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years ago by jaraco

Modified:
5 years ago

Reviewers:
storchaka

CC:
rhettinger, jaraco, jwilk_jwilk.net, devnull_psf.upfronthosting.co.za, storchaka

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 5 years ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/functools.py	View		1 chunk	+6 lines, -0 lines	1 comment	Download
		Lib/test/test_functools.py	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

storchaka_gmail.com

5 years ago #1

http://bugs.python.org/review/22184/diff/12696/Lib/functools.py
File Lib/functools.py (right):

http://bugs.python.org/review/22184/diff/12696/Lib/functools.py#newcode398
Lib/functools.py:398: if not isinstance(maxsize, int):
maxsize can be None.

And may be accept any integer-like object (this would be consistent with
handling similar arguments in C implementations)?

if maxsize is not None:
    maxsize = operator.index(maxsize)

It would be good also specify the behavior when maxsize < 0.

Expand All Messages | Collapse All Messages