Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164975)

#22153: There is no standard TestCase.runTest implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by vadmium+py
Modified:
5 years ago
Reviewers:
robertc, ezio.melotti, berker.peksag
CC:
AntoinePitrou, rbcollins, ezio.melotti, Michael Foord, docs_python.org, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, losvampires_yahoo.com
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/unittest.rst View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6
rbcollins
Looks fine to me - discussion is still simmering on the issue, will commit once ...
5 years, 1 month ago #1
ezio.melotti
http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst File Doc/library/unittest.rst (right): http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst#newcode657 Doc/library/unittest.rst:657: In most uses of :class:`TestCase`, you will neither change ...
5 years, 1 month ago #2
rbcollins
http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst File Doc/library/unittest.rst (right): http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst#newcode657 Doc/library/unittest.rst:657: In most uses of :class:`TestCase`, you will neither change ...
5 years, 1 month ago #3
Martin Panter
http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst File Doc/library/unittest.rst (right): http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst#newcode1561 Doc/library/unittest.rst:1561: If no methods with the usual name prefix are ...
5 years, 1 month ago #4
ezio.melotti
On 2014/11/10 22:24:13, vadmium wrote: > http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst > File Doc/library/unittest.rst (right): > > http://bugs.python.org/review/22153/diff/12734/Doc/library/unittest.rst#newcode1561 > ...
5 years, 1 month ago #5
berkerpeksag
5 years ago #6
LGTM.

http://bugs.python.org/review/22153/diff/13362/Doc/library/unittest.rst
File Doc/library/unittest.rst (right):

http://bugs.python.org/review/22153/diff/13362/Doc/library/unittest.rst#newco...
Doc/library/unittest.rst:1561: A test case instance is created for each method
named by
This part does not apply to the correct place:

    $ hg imp --no-c http://bugs.python.org/file37372/runtest.patch
    applying http://bugs.python.org/file37372/runtest.patch
    patching file Doc/library/unittest.rst
    Hunk #2 succeeded at 1554 with fuzz 2 (offset -6 lines).
    applied to working directory

And here is the output of "hg diff":

    :class:`TestLoader` objects have the following attributes:
 
+      A test case instance is created for each method named by
+      :meth:`getTestCaseNames`. By default these are the method names
+      beginning with *test*. If :meth:`getTestCaseNames` returns no methods,
+      but the :meth:`runTest` method is implemented, a single test case is
+      created for that method instead.
 
    .. attribute:: errors

http://bugs.python.org/review/22153/diff/13362/Doc/library/unittest.rst#newco...
Doc/library/unittest.rst:1563: beginning with *test*. If
:meth:`getTestCaseNames` returns no methods,
*test* -> ``test``
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+