Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75541)

#22095: Use of set_tunnel with default port results in incorrect post value in host header

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by demianbrecht
Modified:
4 years, 8 months ago
Reviewers:
berker.peksag, storchaka
CC:
orsenthil, Nikratio, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, demian
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/http/client.py View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
Lib/test/test_httplib.py View 1 2 2 chunks +6 lines, -3 lines 2 comments Download

Messages

Total messages: 5
berkerpeksag
http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py#newcode1271 Lib/test/test_httplib.py:1271: self.assertTrue(b'Host: destination.com:None' not in assertNotIn http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py#newcode1274 Lib/test/test_httplib.py:1274: _sendall = ...
4 years, 8 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py#newcode1269 Lib/test/test_httplib.py:1269: inst.data += data Instead of changing an instance attributes, ...
4 years, 8 months ago #2
demian
http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/22095/diff/13318/Lib/test/test_httplib.py#newcode1269 Lib/test/test_httplib.py:1269: inst.data += data On 2014/11/30 17:51:14, storchaka wrote: > ...
4 years, 8 months ago #3
berkerpeksag
LGTM. Thanks! http://bugs.python.org/review/22095/diff/13394/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/22095/diff/13394/Lib/test/test_httplib.py#newcode7 Lib/test/test_httplib.py:7: import types Unused import.
4 years, 8 months ago #4
storchaka_gmail.com
4 years, 8 months ago #5
https://bugs.python.org/review/22095/diff/13394/Lib/test/test_httplib.py
File Lib/test/test_httplib.py (right):

https://bugs.python.org/review/22095/diff/13394/Lib/test/test_httplib.py#newc...
Lib/test/test_httplib.py:1305: self.assertNotIn(b'Host: destination.com:None',
conn.sock.data)
Trailing whitespace.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+