Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158235)

#21965: Add support for Memory BIO to _ssl

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by geertj
Modified:
5 years, 2 months ago
Reviewers:
pitrou
CC:
gvanrossum, geertj, bill.janssen_gmail.com, AntoinePitrou, haypo, giampaolo.rodola, christian.heimes, ezio.melotti, alex, devnull_psf.upfronthosting.co.za, sbt, Ben.Darnell, Yury Selivanov, dstufft, chatgris_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 13

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 2 3 4 4 chunks +168 lines, -0 lines 0 comments Download
Lib/ssl.py View 1 2 3 4 10 chunks +139 lines, -24 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 4 4 chunks +160 lines, -2 lines 0 comments Download
Modules/_ssl.c View 1 2 3 4 33 chunks +460 lines, -80 lines 0 comments Download

Messages

Total messages: 3
AntoinePitrou
http://bugs.python.org/review/21965/diff/12382/Lib/test/test_ssl.py File Lib/test/test_ssl.py (right): http://bugs.python.org/review/21965/diff/12382/Lib/test/test_ssl.py#newcode1657 Lib/test/test_ssl.py:1657: offset += self.retry_eintr(sock.send, buf[offset:]) The socket seems to be ...
5 years, 4 months ago #1
geertj
http://bugs.python.org/review/21965/diff/12382/Lib/test/test_ssl.py File Lib/test/test_ssl.py (right): http://bugs.python.org/review/21965/diff/12382/Lib/test/test_ssl.py#newcode1657 Lib/test/test_ssl.py:1657: offset += self.retry_eintr(sock.send, buf[offset:]) You are right, I will ...
5 years, 4 months ago #2
geertj
5 years, 4 months ago #3
I will update a new patch taking care of the suggestions.

http://bugs.python.org/review/21965/diff/12382/Modules/_ssl.c
File Modules/_ssl.c (right):

http://bugs.python.org/review/21965/diff/12382/Modules/_ssl.c#newcode1910
Modules/_ssl.c:1910: Py_INCREF(Py_None);
OK

http://bugs.python.org/review/21965/diff/12382/Modules/_ssl.c#newcode3332
Modules/_ssl.c:3332: BIO_set_retry_read(bio);
OK

http://bugs.python.org/review/21965/diff/12382/Modules/_ssl.c#newcode3416
Modules/_ssl.c:3416: if (!PyArg_ParseTuple(args, "y*:write", &buf))
OK will add it

http://bugs.python.org/review/21965/diff/12382/Modules/_ssl.c#newcode3450
Modules/_ssl.c:3450: BIO_clear_retry_flags(self->bio);
Will add a comment to the next patch.

This clears the "should retry" flag which is the EOF indicator for non-blocking
BIOs. When the BIO read() returns 0, the SSL routines check this flag to see if
more data can be expected later, or not.

http://bugs.python.org/review/21965/diff/12382/Modules/_ssl.c#newcode3501
Modules/_ssl.c:3501: Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,  /*tp_flags*/
I'll remove it. Copied it from the boilerplate.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+