Issue 21804: Implement thr UTF8 command (RFC 6856) in poplib.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#21804: Implement thr UTF8 command (RFC 6856) in poplib.

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 5 months ago by milan.py

Modified:
5 years, 4 months ago

Reviewers:
jimjjewett

CC:
barry, AntoinePitrou, r.david.murray, jesstess, devnull_psf.upfronthosting.co.za, zvyn

Visibility:
Public.

Patch Set 3 #

Created: 5 years, 4 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/library/poplib.rst	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
Lib/poplib.py	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
Lib/test/test_poplib.py	View	1 2	3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jim.J.Jewett

http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py File Lib/poplib.py (right): http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py#newcode73 Lib/poplib.py:73: STLS stls() Should UTF8 be added to this list? ...

5 years, 4 months ago #1

zvyn

5 years, 4 months ago #2

Thanks for your comments, Jim!

http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py
File Lib/poplib.py (right):

http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py#newcode73
Lib/poplib.py:73: STLS                    stls()
On 2014/06/23 15:24:37, Jim.J.Jewett wrote:
> Should UTF8 be added to this list?
Yes, I missed that.

http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py#newcode350
Lib/poplib.py:350: return self._shortcmd('UTF8')
On 2014/06/23 15:24:37, Jim.J.Jewett wrote:
> What happens if the server does not support UTF-8 mode?
The server responds with an error. (I'll try to make that clear in the next
version of the patch.) This behaviour is consistent with the other optional
commands (except stls() where it would be a security issue).

> Is that tested? Is there a base server in the stdlib, and if so, does that
> support it?
It is tested but we do not have a real server in the stdlib. I implemented
enough of RFC 6856 in the dummy test server to simulate a successful call.
Testing the opposite is pointless because the existing test really just checks
that the server responds to utf8() and I would just replace '+OK' by '-ERR'
there.

Expand All Messages | Collapse All Messages

#21804: Implement thr UTF8 command (RFC 6856) in poplib.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Messages