http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py File Lib/poplib.py (right): http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py#newcode73 Lib/poplib.py:73: STLS stls() Should UTF8 be added to this list? ...
Thanks for your comments, Jim!
http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py
File Lib/poplib.py (right):
http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py#newcode73
Lib/poplib.py:73: STLS stls()
On 2014/06/23 15:24:37, Jim.J.Jewett wrote:
> Should UTF8 be added to this list?
Yes, I missed that.
http://bugs.python.org/review/21804/diff/12206/Lib/poplib.py#newcode350
Lib/poplib.py:350: return self._shortcmd('UTF8')
On 2014/06/23 15:24:37, Jim.J.Jewett wrote:
> What happens if the server does not support UTF-8 mode?
The server responds with an error. (I'll try to make that clear in the next
version of the patch.) This behaviour is consistent with the other optional
commands (except stls() where it would be a security issue).
> Is that tested? Is there a base server in the stdlib, and if so, does that
> support it?
It is tested but we do not have a real server in the stdlib. I implemented
enough of RFC 6856 in the dummy test server to simulate a successful call.
Testing the opposite is pointless because the existing test really just checks
that the server responds to utf8() and I would just replace '+OK' by '-ERR'
there.
Issue 21804: Implement thr UTF8 command (RFC 6856) in poplib.
Created 4 years, 8 months ago by zvyn
Modified 4 years, 7 months ago
Reviewers: Jim.J.Jewett
Base URL: None
Comments: 4