Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(274994)

#21725: RFC 6531 (SMTPUTF8) support in smtpd

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by rdmurray
Modified:
5 years ago
Reviewers:
milan.py, storchaka
CC:
barry, AntoinePitrou, r.david.murray, jesstess, devnull_psf.upfronthosting.co.za, storchaka, zvyn
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 33

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Patch Set 9 #

Total comments: 3

Patch Set 10 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/smtpd.py View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -7 lines 0 comments Download
Lib/test/test_smtpd.py View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r.david.murray
http://bugs.python.org/review/21725/diff/12189/Doc/library/smtpd.rst File Doc/library/smtpd.rst (right): http://bugs.python.org/review/21725/diff/12189/Doc/library/smtpd.rst#newcode46 Doc/library/smtpd.rst:46: :meth:`process_unicode_message` to support ``SMTPUTF8``. This is not a good ...
5 years, 2 months ago #1
zvyn
http://bugs.python.org/review/21725/diff/12189/Lib/smtpd.py File Lib/smtpd.py (right): http://bugs.python.org/review/21725/diff/12189/Lib/smtpd.py#newcode174 Lib/smtpd.py:174: skip_greeting=False, On 2014/06/17 21:47:44, r.david.murray wrote: > Instead of ...
5 years, 2 months ago #2
storchaka_gmail.com
5 years ago #3
http://bugs.python.org/review/21725/diff/12672/Lib/smtpd.py
File Lib/smtpd.py (right):

http://bugs.python.org/review/21725/diff/12672/Lib/smtpd.py#newcode126
Lib/smtpd.py:126: return max(self.command_size_limits.values())
max() now has the "default" parameter. This code can be simplified to:

return max(self.command_size_limits.values(),
           default=self.command_size_limit)

http://bugs.python.org/review/21725/diff/12672/Lib/smtpd.py#newcode140
Lib/smtpd.py:140: ValueError("decode_data and enable_SMTPUTF8 cannot be set to"
Forgot "raise".

http://bugs.python.org/review/21725/diff/12672/Lib/smtpd.py#newcode746
Lib/smtpd.py:746: if 'enable_SMTPUTF8' in kwargs and kwargs['enable_SMTPUTF8']:
This can be written as kwargs.get('enable_SMTPUTF8').
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+