Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

#21722: teach distutils "upload" to exit with code != 0 when error occurs

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by martin
Modified:
3 years, 5 months ago
Reviewers:
pitrou
CC:
AntoinePitrou, eric.araujo, devnull_psf.upfronthosting.co.za, mdengler, dstufft
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/distutils/command/upload.py View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
Lib/distutils/tests/test_upload.py View 1 2 3 4 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 2
AntoinePitrou
Just one small nit: since it's trivial, you don't have to resubmit your patch, I ...
3 years, 5 months ago #1
mdengler
3 years, 5 months ago #2
Thanks for the review and the feedback!

http://bugs.python.org/review/21722/diff/12129/Lib/distutils/tests/test_uploa...
File Lib/distutils/tests/test_upload.py (right):

http://bugs.python.org/review/21722/diff/12129/Lib/distutils/tests/test_uploa...
Lib/distutils/tests/test_upload.py:148: self.next_msg = None
On 2014/06/18 23:16:41, AntoinePitrou wrote:
> You don't need to reset them, since setUp() is run before each individual
test.

True!  I just thought things would be more obviously tidied up, so no knowledge
of setUp() -- and potential for setUp() changing -- was necessary...but I take
your point.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7