Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

#21717: Exclusive mode for ZipFile and TarFile

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by anntzer.lee
Modified:
5 years ago
Reviewers:
storchaka, berker.peksag
CC:
lars.gustaebel, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, Antony.Lee
Visibility:
Public.

Patch Set 1 #

Total comments: 12

Patch Set 2 #

Total comments: 27

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Total comments: 14

Patch Set 5 #

Total comments: 4

Patch Set 6 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/tarfile.rst View 1 2 3 4 5 5 chunks +29 lines, -8 lines 0 comments Download
Doc/whatsnew/3.5.rst View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
Lib/tarfile.py View 1 2 3 4 5 8 chunks +24 lines, -15 lines 0 comments Download
Lib/test/test_tarfile.py View 1 2 3 4 5 1 chunk +83 lines, -0 lines 1 comment Download

Messages

Total messages: 23
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/12244/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/21717/diff/12244/Lib/tarfile.py#newcode1526 Lib/tarfile.py:1526: 'x' or 'x:*' create a tarfile with transparent compression, ...
5 years, 7 months ago #1
berkerpeksag
http://bugs.python.org/review/21717/diff/12244/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/21717/diff/12244/Lib/tarfile.py#newcode1526 Lib/tarfile.py:1526: 'x' or 'x:*' create a tarfile with transparent compression, ...
5 years, 2 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13851/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/tarfile.py#newcode1527 Lib/tarfile.py:1527: 'x' create a tarfile with transparent compression, raise an ...
5 years, 2 months ago #3
berkerpeksag
http://bugs.python.org/review/21717/diff/13851/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/tarfile.py#newcode1527 Lib/tarfile.py:1527: 'x' create a tarfile with transparent compression, raise an ...
5 years, 1 month ago #4
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13851/Lib/tarfile.py File Lib/tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/tarfile.py#newcode1527 Lib/tarfile.py:1527: 'x' create a tarfile with transparent compression, raise an ...
5 years, 1 month ago #5
berkerpeksag
http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode104 Lib/test/test_tarfile.py:104: tarname = os.path.join(TEMPDIR, "testtar_x.tar") On 2015/02/06 14:29:04, storchaka wrote: ...
5 years, 1 month ago #6
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode145 Lib/test/test_tarfile.py:145: class GzipUstarTransparentCompressionCreateTest(UstarTransparentCompressionCreateTest): On 2015/02/08 20:23:50, berkerpeksag wrote: > On ...
5 years, 1 month ago #7
berkerpeksag
http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode137 Lib/test/test_tarfile.py:137: def test_open_classmethod(self): On 2015/02/06 14:29:04, storchaka wrote: > I ...
5 years, 1 month ago #8
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode137 Lib/test/test_tarfile.py:137: def test_open_classmethod(self): On 2015/02/09 20:05:03, berkerpeksag wrote: > On ...
5 years, 1 month ago #9
berkerpeksag
http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode104 Lib/test/test_tarfile.py:104: tarname = os.path.join(TEMPDIR, "testtar_x.tar") On 2015/02/06 14:29:04, storchaka wrote: ...
5 years, 1 month ago #10
berkerpeksag
On 2015/02/09 20:42:01, storchaka wrote: > http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py > File Lib/test/test_tarfile.py (right): > > http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode137 > ...
5 years, 1 month ago #11
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode104 Lib/test/test_tarfile.py:104: tarname = os.path.join(TEMPDIR, "testtar_x.tar") On 2015/02/09 20:47:13, berkerpeksag wrote: ...
5 years, 1 month ago #12
berkerpeksag
On 2015/02/09 22:45:24, storchaka wrote: > http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py > File Lib/test/test_tarfile.py (right): > > http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py#newcode104 > ...
5 years, 1 month ago #13
storchaka_gmail.com
On 2015/02/10 12:28:56, berkerpeksag wrote: > On 2015/02/09 22:45:24, storchaka wrote: > > http://bugs.python.org/review/21717/diff/13851/Lib/test/test_tarfile.py > ...
5 years, 1 month ago #14
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13895/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13895/Lib/test/test_tarfile.py#newcode87 Lib/test/test_tarfile.py:87: tarname = tmpname Just use tmpname in tests, not ...
5 years, 1 month ago #15
berkerpeksag
http://bugs.python.org/review/21717/diff/13895/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13895/Lib/test/test_tarfile.py#newcode87 Lib/test/test_tarfile.py:87: tarname = tmpname On 2015/02/10 13:44:12, storchaka wrote: > ...
5 years, 1 month ago #16
berkerpeksag
5 years, 1 month ago #17
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13895/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13895/Lib/test/test_tarfile.py#newcode158 Lib/test/test_tarfile.py:158: class GzipTransparentCompressionCreateTest(TransparentCompressionCreateTest, GzipTest): On 2015/02/10 16:22:20, berkerpeksag wrote: > ...
5 years, 1 month ago #18
storchaka_gmail.com
http://bugs.python.org/review/21717/diff/13906/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13906/Lib/test/test_tarfile.py#newcode127 Lib/test/test_tarfile.py:127: Here needed the same test with reading tar file. ...
5 years, 1 month ago #19
berkerpeksag
http://bugs.python.org/review/21717/diff/13906/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): http://bugs.python.org/review/21717/diff/13906/Lib/test/test_tarfile.py#newcode127 Lib/test/test_tarfile.py:127: On 2015/02/11 17:07:03, storchaka wrote: > Here needed the ...
5 years, 1 month ago #20
storchaka_gmail.com
Great! Expect one minor nitpick the patch LGTM. https://bugs.python.org/review/21717/diff/13918/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): https://bugs.python.org/review/21717/diff/13918/Lib/test/test_tarfile.py#newcode1508 Lib/test/test_tarfile.py:1508: suffix ...
5 years, 1 month ago #21
berkerpeksag
LGTM. Adding a whatsnew entry would be nice. http://bugs.python.org/review/21717/diff/13853/Doc/library/zipfile.rst File Doc/library/zipfile.rst (right): http://bugs.python.org/review/21717/diff/13853/Doc/library/zipfile.rst#newcode140 Doc/library/zipfile.rst:140: :exc:`FileExistsError` ...
5 years ago #22
storchaka_gmail.com
5 years ago #23
Thank you Berker.

http://bugs.python.org/review/21717/diff/13853/Doc/library/zipfile.rst
File Doc/library/zipfile.rst (right):

http://bugs.python.org/review/21717/diff/13853/Doc/library/zipfile.rst#newcod...
Doc/library/zipfile.rst:140: :exc:`FileExistsError` will be raised.
On 2015/03/25 08:42:11, berkerpeksag wrote:
> a :exc:`FileExistsError` will be raised.

Done.

http://bugs.python.org/review/21717/diff/13853/Lib/zipfile.py
File Lib/zipfile.py (right):

http://bugs.python.org/review/21717/diff/13853/Lib/zipfile.py#newcode962
Lib/zipfile.py:962: raise RuntimeError("ZipFile() requires mode 'r', 'w', 'x',
or 'a'")
On 2015/03/25 08:42:11, berkerpeksag wrote:
> no need to add () in my opinion

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+