Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

#21694: IDLE - Test ParenMatch

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by saimadhavheblikar
Modified:
5 years, 9 months ago
Reviewers:
tjreedy
CC:
terry.reedy, taleinat, jesstess, devnull_psf.upfronthosting.co.za, sahutd
Visibility:
Public.

Patch Set 1 #

Total comments: 14

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/idlelib/HyperParser.py View 1 2 3 4 3 chunks +10 lines, -3 lines 0 comments Download
Lib/idlelib/ParenMatch.py View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
terry.reedy
http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/ParenMatch.py File Lib/idlelib/ParenMatch.py (right): http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/ParenMatch.py#newcode94 Lib/idlelib/ParenMatch.py:94: "insert").get_surrounding_brackets() Too ugly, see patch for alterntive. http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_parenmatch.py File ...
5 years, 9 months ago #1
sahutd
5 years, 9 months ago #2
http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/ParenMatch.py
File Lib/idlelib/ParenMatch.py (right):

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/ParenMatch.py#newc...
Lib/idlelib/ParenMatch.py:94: "insert").get_surrounding_brackets()
On 2014/06/13 07:57:10, terry.reedy wrote:
> Too ugly, see patch for alterntive.

Done.

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
File Lib/idlelib/idle_test/test_parenmatch.py (right):

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
Lib/idlelib/idle_test/test_parenmatch.py:6: from tkinter import Text
On 2014/06/13 07:57:10, terry.reedy wrote:
> Must import Tk to save root and destroy on exit.

Done.

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
Lib/idlelib/idle_test/test_parenmatch.py:21: cls.text = Text()
On 2014/06/13 07:57:10, terry.reedy wrote:
> see patch

Done.

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
Lib/idlelib/idle_test/test_parenmatch.py:24: cls.orig_style = ParenMatch.STYLE
On 2014/06/13 07:57:10, terry.reedy wrote:
> Monkey-patching unnecessry. Used pm.set_style in methods.

Done.

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
Lib/idlelib/idle_test/test_parenmatch.py:38: Test ParenMatch with 'expression'
style
On 2014/06/13 07:57:10, terry.reedy wrote:
> Guido likes periods at end of docstring sentences, especially the first one.

Done.

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
Lib/idlelib/idle_test/test_parenmatch.py:79: Test corner cases in
flash_paren_event and paren_closed_event
On 2014/06/13 07:57:10, terry.reedy wrote:
> Both methods always return None.  But I see that these exercise conditional
> expresssions and alternate paths. Added comment to that effect.
In your patch, was the comment missing some parts?

http://bugs.python.org/review/21694/diff/12095/Lib/idlelib/idle_test/test_par...
Lib/idlelib/idle_test/test_parenmatch.py:104: unittest.main(verbosity=2,
exit=False)
On 2014/06/13 07:57:10, terry.reedy wrote:
> Whatever I said in README a years ago, something changed and exit=False is
only
> needed to not exit user process when there is more code in the module, such as
> an htest.
> 
> It least this is true running normally. I should though check running in one
> process with -n.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+