Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86156)

#21650: add json.tool option to avoid alphabetic sort of fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by p.i.kazlou
Modified:
4 years, 9 months ago
Reviewers:
storchaka, vadmium+py, berker.peksag
CC:
rhettinger, AntoinePitrou, ezio.melotti, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, p.i.kazlou_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 5

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/json.rst View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
Doc/whatsnew/3.5.rst View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
Lib/json/tool.py View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
Lib/test/test_json/test_tool.py View 1 2 3 2 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 4
storchaka_gmail.com
http://bugs.python.org/review/21650/diff/12162/Doc/library/json.rst File Doc/library/json.rst (right): http://bugs.python.org/review/21650/diff/12162/Doc/library/json.rst#newcode616 Doc/library/json.rst:616: .. cmdoption:: --unsorted Just a nitpick. May be name ...
4 years, 10 months ago #1
Martin Panter
https://bugs.python.org/review/21650/diff/12162/Doc/library/json.rst File Doc/library/json.rst (right): https://bugs.python.org/review/21650/diff/12162/Doc/library/json.rst#newcode616 Doc/library/json.rst:616: .. cmdoption:: --unsorted Or you could just leave it ...
4 years, 10 months ago #2
storchaka_gmail.com
Besides one small nitpick the patch LGTM. http://bugs.python.org/review/21650/diff/13192/Doc/whatsnew/3.5.rst File Doc/whatsnew/3.5.rst (right): http://bugs.python.org/review/21650/diff/13192/Doc/whatsnew/3.5.rst#newcode219 Doc/whatsnew/3.5.rst:219: of dictionaries ...
4 years, 9 months ago #3
berkerpeksag
4 years, 9 months ago #4
http://bugs.python.org/review/21650/diff/13192/Doc/whatsnew/3.5.rst
File Doc/whatsnew/3.5.rst (right):

http://bugs.python.org/review/21650/diff/13192/Doc/whatsnew/3.5.rst#newcode219
Doc/whatsnew/3.5.rst:219: of dictionaries by their key (contributed by Berker
Peksag in :issue:`21650`).
On 2014/11/02 19:22:46, storchaka wrote:
> Please be consistent with the rest of the file.
> 
>   of dictionaries by their key. (Contributed by Berker Peksag in
> :issue:`21650`.)

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+