Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

#21552: String length overflow in Tkinter

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by storchaka+cpython
Modified:
3 years, 12 months ago
Reviewers:
victor.stinner
CC:
loewis, ggpolo_gmail.com, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_tcl.py View 1 2 2 chunks +67 lines, -1 line 0 comments Download
Modules/_tkinter.c View 1 2 19 chunks +129 lines, -62 lines 0 comments Download

Messages

Total messages: 2
victor.stinner_gmail.com
http://bugs.python.org/review/21552/diff/11920/Lib/test/test_tcl.py File Lib/test/test_tcl.py (right): http://bugs.python.org/review/21552/diff/11920/Lib/test/test_tcl.py#newcode176 Lib/test/test_tcl.py:176: It would be nice to have a "bigmem" test ...
4 years ago #1
storchaka_gmail.com
4 years ago #2
http://bugs.python.org/review/21552/diff/11920/Lib/test/test_tcl.py
File Lib/test/test_tcl.py (right):

http://bugs.python.org/review/21552/diff/11920/Lib/test/test_tcl.py#newcode176
Lib/test/test_tcl.py:176: 
On 2014/05/22 17:22:23, haypo wrote:
> It would be nice to have a "bigmem" test with strings larger than 2 GB, to
test
> the "len > INT_MAX" code path at least once ;-)

Yes, but writing and testing correct bigmem tests is too burdensome, I will do
this later. May be.

http://bugs.python.org/review/21552/diff/11920/Modules/_tkinter.c
File Modules/_tkinter.c (right):

http://bugs.python.org/review/21552/diff/11920/Modules/_tkinter.c#newcode944
Modules/_tkinter.c:944: if (PyUnicode_Check(in)) {
On 2014/05/22 17:22:23, haypo wrote:
> You should reuse short_string_converter() here to reduce duplication of code.

It reports different error message.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7