Issue 21469: Hazards in robots.txt parser

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#21469: Hazards in robots.txt parser

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 7 months ago by raymond.hettinger

Modified:
5 years, 7 months ago

Reviewers:
ethan, taleinat

CC:
Skip, rhettinger, taleinat, stoneleaf, devnull_psf.upfronthosting.co.za

Visibility:
Public.

Patch Set 2 #

Total comments: 1

Created: 5 years, 7 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/urllib/robotparser.py	View	1	4 chunks	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

stoneleaf

changes look good, just one question about the reference doc http://bugs.python.org/review/21469/diff/11842/Lib/urllib/robotparser.py File Lib/urllib/robotparser.py (right): http://bugs.python.org/review/21469/diff/11842/Lib/urllib/robotparser.py#newcode10 ...

5 years, 7 months ago #1

LGTM

Expand All Messages | Collapse All Messages

#21469: Hazards in robots.txt parser

Patch Set 1 #

Patch Set 2 #

Messages