Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33231)

#21423: concurrent.futures.ThreadPoolExecutor should accept an initializer argument

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by A.W.van.Cranenburgh
Modified:
4 years, 3 months ago
Reviewers:
pitrou, oreilldf, blckknght
CC:
Vinay Sajip, bquinlan, mark.dickinson, AntoinePitrou, giampaolo.rodola, Claudiu.Popa, jcon, storchaka, mdengler, pedro_algarvio.me, thehesiod, Josh.R, A.W.van.Cranenburgh_rug.nl, dan.oreilly, nicholas.chammas_gmail.com, heshiming_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 9

Patch Set 5 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/concurrent.futures.rst View 1 2 3 4 3 chunks +23 lines, -2 lines 2 comments Download
Lib/concurrent/futures/process.py View 1 2 3 4 9 chunks +62 lines, -9 lines 0 comments Download
Lib/concurrent/futures/thread.py View 1 2 3 4 4 chunks +37 lines, -5 lines 0 comments Download
Lib/test/test_concurrent_futures.py View 1 2 3 4 5 chunks +64 lines, -1 line 0 comments Download

Messages

Total messages: 4
AntoinePitrou
http://bugs.python.org/review/21423/diff/12678/Lib/concurrent/futures/process.py File Lib/concurrent/futures/process.py (right): http://bugs.python.org/review/21423/diff/12678/Lib/concurrent/futures/process.py#newcode218 Lib/concurrent/futures/process.py:218: except queue.Full: Is this new except clause meant to ...
4 years, 10 months ago #1
dan.oreilly
http://bugs.python.org/review/21423/diff/12678/Lib/concurrent/futures/process.py File Lib/concurrent/futures/process.py (right): http://bugs.python.org/review/21423/diff/12678/Lib/concurrent/futures/process.py#newcode218 Lib/concurrent/futures/process.py:218: except queue.Full: It's introduced by the changes. When an ...
4 years, 10 months ago #2
dan.oreilly
http://bugs.python.org/review/21423/diff/12678/Lib/concurrent/futures/process.py File Lib/concurrent/futures/process.py (right): http://bugs.python.org/review/21423/diff/12678/Lib/concurrent/futures/process.py#newcode218 Lib/concurrent/futures/process.py:218: except queue.Full: The more I test this, this more ...
4 years, 10 months ago #3
Steven.Barker
4 years, 3 months ago #4
The patch looks good to me (for whatever that's worth), except for a small typo
in the docs, repeated in two places.

http://bugs.python.org/review/21423/diff/12682/Doc/library/concurrent.futures...
File Doc/library/concurrent.futures.rst (right):

http://bugs.python.org/review/21423/diff/12682/Doc/library/concurrent.futures...
Doc/library/concurrent.futures.rst:127: raise a :exc:`RuntimeError`, as well any
attempt to submit more jobs to
"well" should be "will"

http://bugs.python.org/review/21423/diff/12682/Doc/library/concurrent.futures...
Doc/library/concurrent.futures.rst:196: raise a :exc:`RuntimeError`, as well any
attempt to submit more jobs to
"well" should be "will" here too.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+