Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

#21408: delegation of `!=` to the right-hand side argument is not always done

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by jean-paul
Modified:
4 years, 12 months ago
Reviewers:
storchaka
CC:
exarkun, Benjamin Peterson, Arfrever, r.david.murray, flox, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, Josh.R
Base URL:
x
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/_collections_abc.py View 1 2 chunks +0 lines, -6 lines 0 comments Download
Lib/doctest.py View 1 3 chunks +0 lines, -9 lines 0 comments Download
Lib/lib2to3/pytree.py View 1 1 chunk +0 lines, -10 lines 0 comments Download
Lib/numbers.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
Lib/pathlib.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
Lib/test/test_binop.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
Lib/test/test_compare.py View 1 1 chunk +63 lines, -2 lines 0 comments Download
Lib/unittest/case.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
Lib/unittest/suite.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
Objects/typeobject.c View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 1
storchaka_gmail.com
4 years, 12 months ago #1
http://bugs.python.org/review/21408/diff/13596/Lib/test/test_compare.py
File Lib/test/test_compare.py (right):

http://bugs.python.org/review/21408/diff/13596/Lib/test/test_compare.py#newco...
Lib/test/test_compare.py:51: self.assertIs(True, a == b)
Usually first argument is actual value and second argument is expected value.

http://bugs.python.org/review/21408/diff/13596/Lib/test/test_compare.py#newco...
Lib/test/test_compare.py:57: calls = list()
Just [].

http://bugs.python.org/review/21408/diff/13596/Lib/test/test_compare.py#newco...
Lib/test/test_compare.py:100: for [name, func] in ops:
It looks very unusual to use a list for tuple unpack. Brackets are redundant
here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+