Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3727)

#21042: ctypes.util.find_library() should return full pathname instead of filename in linux

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by hgrecco
Modified:
3 years, 1 month ago
Reviewers:
vadmium+py
CC:
devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, hgrecco_gmail.com, beng94
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Total comments: 1

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ctypes.rst View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
Lib/ctypes/test/test_find.py View 1 2 3 4 2 chunks +24 lines, -16 lines 0 comments Download
Lib/ctypes/util.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Martin Panter
https://bugs.python.org/review/21042/diff/16482/Lib/ctypes/util.py File Lib/ctypes/util.py (left): https://bugs.python.org/review/21042/diff/16482/Lib/ctypes/util.py#oldcode225 Lib/ctypes/util.py:225: '\s+(lib%s\.[^\s]+)\s+\(%s' % (re.escape(name), abi_type)) Why did you remove the ...
3 years, 1 month ago #1
Martin Panter
https://bugs.python.org/review/21042/diff/16509/Lib/ctypes/util.py File Lib/ctypes/util.py (right): https://bugs.python.org/review/21042/diff/16509/Lib/ctypes/util.py#newcode225 Lib/ctypes/util.py:225: '([^\s]+lib%s\.[^\s]+)\\n\\t[^\s]+\s\(%s' % (re.escape(name), abi_type)) I suggest a raw string ...
3 years, 1 month ago #2
Martin Panter
3 years, 1 month ago #3
https://bugs.python.org/review/21042/diff/16629/Lib/ctypes/test/test_find.py
File Lib/ctypes/test/test_find.py (right):

https://bugs.python.org/review/21042/diff/16629/Lib/ctypes/test/test_find.py#...
Lib/ctypes/test/test_find.py:68: lib_gl = lib_glu = lib_gle = None
I would change setUpClass() to save all these in cls.gl_path, etc. Then you
don’t need to duplicate the code :)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+