Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161398)

#20951: SSLSocket.send() returns 0 for non-blocking socket

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by Nikolaus
Modified:
5 years, 7 months ago
Reviewers:
berker.peksag, pitrou
CC:
bill.janssen_gmail.com, AntoinePitrou, giampaolo.rodola, christian.heimes, r.david.murray, Nikratio, devnull_psf.upfronthosting.co.za, Ben.Darnell
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 2 3 4 3 chunks +77 lines, -7 lines 2 comments Download
Lib/ssl.py View 1 2 3 4 1 chunk +1 line, -11 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 4 1 chunk +29 lines, -0 lines 2 comments Download

Messages

Total messages: 6
berkerpeksag
http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst#newcode792 Doc/library/ssl.rst:792: .. versionchanged:: 3.5 This should be "versionadded". http://bugs.python.org/review/20951/diff/11361/Lib/ssl.py File ...
5 years, 8 months ago #1
Nikratio
http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst#newcode792 Doc/library/ssl.rst:792: .. versionchanged:: 3.5 On 2014/03/19 10:04:58, berkerpeksag wrote: > ...
5 years, 8 months ago #2
berkerpeksag
http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst#newcode773 Doc/library/ssl.rst:773: Set blocking or non-blocking mode of the socket: if ...
5 years, 8 months ago #3
Nikratio
http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/20951/diff/11361/Doc/library/ssl.rst#newcode773 Doc/library/ssl.rst:773: Set blocking or non-blocking mode of the socket: if ...
5 years, 8 months ago #4
AntoinePitrou
Thanks for posting the patch, Nikolaus! A couple comments below: http://bugs.python.org/review/20951/diff/11730/Doc/library/ssl.rst File Doc/library/ssl.rst (right): http://bugs.python.org/review/20951/diff/11730/Doc/library/ssl.rst#newcode787 ...
5 years, 7 months ago #5
Nikratio
5 years, 7 months ago #6
http://bugs.python.org/review/20951/diff/11730/Doc/library/ssl.rst
File Doc/library/ssl.rst (right):

http://bugs.python.org/review/20951/diff/11730/Doc/library/ssl.rst#newcode787
Doc/library/ssl.rst:787: .. method:: SSLSocket.recv(bufsize[, flags])
On 2014/04/28 20:03:17, AntoinePitrou wrote:
> I don't think it's useful to explicitly write documentation for recv() and
> friends. The "notes on non-blocking sockets" section should be sufficient (you
> can move the "versionchanged" there).

Done.

http://bugs.python.org/review/20951/diff/11730/Lib/test/test_ssl.py
File Lib/test/test_ssl.py (right):

http://bugs.python.org/review/20951/diff/11730/Lib/test/test_ssl.py#newcode2502
Lib/test/test_ssl.py:2502: self.assertRaises(ssl.SSLWantWriteError, fill_buffer)
On 2014/04/28 20:03:17, AntoinePitrou wrote:
> Actually, it can raise either SSLWantWriteError or SSLWantReadError (the TLS
> protocol might need to *read* stuff before writing encrypted data out).

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+