Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35530)

#20710: Make inspect and pydoc consistent about bound methods

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 12 months ago by larry
Modified:
4 years, 12 months ago
Reviewers:
yselivanov.ml
CC:
Nick Coghlan, larry, devnull_psf.upfronthosting.co.za, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 2

Patch Set 7 #

Total comments: 1

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/pydoc.py View 1 2 3 4 5 6 7 6 chunks +16 lines, -5 lines 0 comments Download
Lib/test/test_pydoc.py View 1 2 3 4 5 6 7 2 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Yury.Selivanov
Looks good to me in general. But, could you please write a unit-test for your ...
4 years, 12 months ago #1
Yury.Selivanov
Just a few more nit-questions about tests. http://bugs.python.org/review/20710/diff/11122/Lib/test/test_pydoc.py File Lib/test/test_pydoc.py (right): http://bugs.python.org/review/20710/diff/11122/Lib/test/test_pydoc.py#newcode571 Lib/test/test_pydoc.py:571: def test_bound_builtin_method(self): ...
4 years, 12 months ago #2
Yury.Selivanov
http://bugs.python.org/review/20710/diff/11122/Lib/test/test_pydoc.py File Lib/test/test_pydoc.py (right): http://bugs.python.org/review/20710/diff/11122/Lib/test/test_pydoc.py#newcode571 Lib/test/test_pydoc.py:571: def test_bound_builtin_method(self): I see that it tests os.stat in ...
4 years, 12 months ago #3
Yury.Selivanov
4 years, 12 months ago #4
Please take a look at one more comment.

And LGTM.

http://bugs.python.org/review/20710/diff/11123/Lib/test/test_pydoc.py
File Lib/test/test_pydoc.py (right):

http://bugs.python.org/review/20710/diff/11123/Lib/test/test_pydoc.py#newcode589
Lib/test/test_pydoc.py:589: def test_module_level_callable(self):
Please see if this one is a duplicate of 'test_pydoc.test_builtin_signatures';
sorry, i must have looked it up myself, before posting a request.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+