Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32002)

#20625: Argument names in __annotations__ are not mangled for functions defined inside class scope

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by j.wielicki
Modified:
5 years, 8 months ago
Reviewers:
bp+pybugs, yselivanov.ml
CC:
nnorwitz_gmail.com, Nick Coghlan, larry, Benjamin Peterson, eric.araujo, Arfrever, devnull_psf.upfronthosting.co.za, Yury Selivanov, j.wielicki_sotecware.net
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_grammar.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
Lib/test/test_inspect.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
Python/compile.c View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4
bp+pybugs_benjamin-peterson.org
Okay except for the C part. http://bugs.python.org/review/20625/diff/11049/Python/compile.c File Python/compile.c (right): http://bugs.python.org/review/20625/diff/11049/Python/compile.c#newcode1537 Python/compile.c:1537: if (mangled) { ...
5 years, 8 months ago #1
Yury.Selivanov
http://bugs.python.org/review/20625/diff/11049/Python/compile.c File Python/compile.c (right): http://bugs.python.org/review/20625/diff/11049/Python/compile.c#newcode1537 Python/compile.c:1537: if (mangled) { Why 'return' if (!mangled)? You still ...
5 years, 8 months ago #2
bp+pybugs_benjamin-peterson.org
On 2014/02/14 23:45:44, yselivanov wrote: > http://bugs.python.org/review/20625/diff/11049/Python/compile.c > File Python/compile.c (right): > > http://bugs.python.org/review/20625/diff/11049/Python/compile.c#newcode1537 > ...
5 years, 8 months ago #3
Yury.Selivanov
5 years, 8 months ago #4
Right, thanks for the explanation!
Please see the new patch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+