Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2846)

#20480: Add ipaddress property to get reverse DNS name

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by leon
Modified:
5 years ago
Reviewers:
eric
CC:
Nick Coghlan, AntoinePitrou, eric.smith, python_hda3.com, devnull_psf.upfronthosting.co.za, Leon Weber
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ipaddress.rst View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
Lib/ipaddress.py View 1 2 3 4 3 chunks +29 lines, -0 lines 0 comments Download
Lib/test/test_ipaddress.py View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1
eric.smith
5 years ago #1
http://bugs.python.org/review/20480/diff/10877/Doc/library/ipaddress.rst
File Doc/library/ipaddress.rst (right):

http://bugs.python.org/review/20480/diff/10877/Doc/library/ipaddress.rst#newc...
Doc/library/ipaddress.rst:156: .. attribute:: reverse_pointer
Needs a versionadded tag.

I think we should explicitly mention here that no DNS lookup is performed. I
realize it says that just the name is returned, but I think a quick note is
still appropriate.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+