Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113392)

#20438: inspect: Deprecate getfullargspec?

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by yselivanov
Modified:
4 years, 6 months ago
Reviewers:
brett, stephane
CC:
brett.cannon, Nick Coghlan, larry, nedbat, r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, Yury Selivanov, matrixise, veky, markus-bugspython_unterwaditzer.net
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/inspect.rst View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
Lib/inspect.py View 1 2 2 chunks +4 lines, -1 line 0 comments Download
Lib/test/test_inspect.py View 1 2 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4
Yury.Selivanov
http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py#newcode955 Lib/inspect.py:955: warnings.warn("Use inspect.signature() instead of inspect.getfullargspec()", DeprecationWarning) does this line ...
5 years, 7 months ago #1
brett.cannon
http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py#newcode953 Lib/inspect.py:953: Use inspect.signature() instead of inspect.getfullargspec(). This should be in ...
5 years, 7 months ago #2
matrixise
Yes, you are right, I will fix it. On 2014/04/15 17:53:07, Yury Selivanov wrote: > ...
5 years, 7 months ago #3
matrixise
5 years, 7 months ago #4
Just after this patch, I run the tests, and there is a lot of places where we
have to change the code, because inspect.getargspec() uses
inspect.getfullargspec() and by the way, we get the warning in the tests.

May be, just inform this function is deprecated in the documentation or change
the code in the tests and the stdlib.

What do you think?
On 2014/04/15 18:06:33, brett.cannon wrote:
> http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py
> File Lib/inspect.py (right):
> 
> http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py#newcode953
> Lib/inspect.py:953: Use inspect.signature() instead of
inspect.getfullargspec().
> This should be in the module documentation and be a naturally phrased sentence
> here in the docstring.
> 
> http://bugs.python.org/review/20438/diff/11607/Lib/inspect.py#newcode955
> Lib/inspect.py:955: warnings.warn("Use inspect.signature() instead of
> inspect.getfullargspec()", DeprecationWarning)
> I'm not sure if we want to physically deprecate it quite yet. I'll discuss on
> the issue.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+