Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205345)

#20414: Python 3.4 has two Overlapped types

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by vstinner
Modified:
5 years, 10 months ago
Reviewers:
martin, shibturn
CC:
gvanrossum, loewis, AntoinePitrou, haypo, larry, sbt, Zach Ware
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/overlapped.c View 1 2 chunks +14 lines, -2 lines 0 comments Download
Modules/_winapi.c View 1 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 2
loewis
http://bugs.python.org/review/20414/diff/10806/Modules/overlapped.c File Modules/overlapped.c (right): http://bugs.python.org/review/20414/diff/10806/Modules/overlapped.c#newcode560 Modules/overlapped.c:560: default: Why is this the default case? I think ...
5 years, 10 months ago #1
sbt
5 years, 10 months ago #2
http://bugs.python.org/review/20414/diff/10806/Modules/overlapped.c
File Modules/overlapped.c (right):

http://bugs.python.org/review/20414/diff/10806/Modules/overlapped.c#newcode560
Modules/overlapped.c:560: default:
Martin's suggestion sounds reasonable to me.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+