Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160798)

#20375: ElementTree: Document handling processing instructions

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by Nikolaus
Modified:
5 years, 8 months ago
Reviewers:
pcmanticore, eliben
CC:
Georg, scoder, ezio.melotti, eric.araujo, eli.bendersky, Nikratio, docs_python.org, Claudiu.Popa, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 6

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 8

Patch Set 6 #

Patch Set 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/xml.etree.elementtree.rst View 1 2 3 4 5 6 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Claudiu.Popa
http://bugs.python.org/review/20375/diff/10762/Lib/test/test_xml_etree.py File Lib/test/test_xml_etree.py (right): http://bugs.python.org/review/20375/diff/10762/Lib/test/test_xml_etree.py#newcode1628 Lib/test/test_xml_etree.py:1628: self.assertTrue(len(tree2.getroot().getchildren()) == 0) Why not self.assertEqual(len(tree..), 0)? http://bugs.python.org/review/20375/diff/10762/Lib/test/test_xml_etree.py#newcode1639 Lib/test/test_xml_etree.py:1639: ...
5 years, 8 months ago #1
Nikratio
http://bugs.python.org/review/20375/diff/10762/Lib/test/test_xml_etree.py File Lib/test/test_xml_etree.py (right): http://bugs.python.org/review/20375/diff/10762/Lib/test/test_xml_etree.py#newcode1628 Lib/test/test_xml_etree.py:1628: self.assertTrue(len(tree2.getroot().getchildren()) == 0) On 2014/03/19 11:48:55, Claudiu.Popa wrote: > ...
5 years, 8 months ago #2
eli.bendersky
http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementtree.rst File Doc/library/xml.etree.elementtree.rst (right): http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementtree.rst#newcode114 Doc/library/xml.etree.elementtree.rst:114: input. Processing instructions and comments can nevertheless be I ...
5 years, 8 months ago #3
Nikratio
5 years, 8 months ago #4
Thanks for your feedback! I've attached an updated patch.

http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementt...
File Doc/library/xml.etree.elementtree.rst (right):

http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementt...
Doc/library/xml.etree.elementtree.rst:114: input. Processing instructions and
comments can nevertheless be
On 2014/04/02 15:26:31, eli.bendersky wrote:
> I think this could be made clearer. Something like "trees built using this
> module's API rather than parsing from XML test can have comments and
processing
> instructions in them, and are included...."
> 

Done.

http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementt...
Doc/library/xml.etree.elementtree.rst:396: Note that the element tree XML parser
skips over comments in the
On 2014/04/02 15:26:31, eli.bendersky wrote:
> Replace "the element tree XML parser" with a properly ReST-linked
"ElementTree",
> as done elsewhere in the document.

Done.

http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementt...
Doc/library/xml.etree.elementtree.rst:399: into to the tree using
:meth:`~Element.insert`,
On 2014/04/02 15:26:31, eli.bendersky wrote:
> I don't think this listing is necessary - there are many ways to create new
> Element nodes...

Done.

http://bugs.python.org/review/20375/diff/11483/Doc/library/xml.etree.elementt...
Doc/library/xml.etree.elementtree.rst:483: instructions in the input instead of
creating objects for them. An
On 2014/04/02 15:26:31, eli.bendersky wrote:
> same comments here as for the previous block.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+