Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168837)

#20351: Add doc examples for DictReader and DictWriter

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by charlesaxel.dein
Modified:
5 years, 4 months ago
Reviewers:
francismb, vadmium+py, matt, andrew.svetlov, ezio.melotti
CC:
rhettinger, ezio.melotti, charlax, docs_python.org, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, zormit
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Total comments: 3

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/csv.rst View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8
francismb
LGTM
5 years, 10 months ago #1
Martin Panter
http://bugs.python.org/review/20351/diff/10699/Doc/library/csv.rst File Doc/library/csv.rst (right): http://bugs.python.org/review/20351/diff/10699/Doc/library/csv.rst#newcode166 Doc/library/csv.rst:166: Wonderful SPAM I think the space argument to print() ...
5 years, 10 months ago #2
maatt
http://bugs.python.org/review/20351/diff/11072/Doc/library/csv.rst File Doc/library/csv.rst (right): http://bugs.python.org/review/20351/diff/11072/Doc/library/csv.rst#newcode161 Doc/library/csv.rst:161: ... reader = csv.DictReader(csvfile) Don't you need to pass ...
5 years, 8 months ago #3
Martin Panter
https://bugs.python.org/review/20351/diff/11072/Doc/library/csv.rst File Doc/library/csv.rst (right): https://bugs.python.org/review/20351/diff/11072/Doc/library/csv.rst#newcode161 Doc/library/csv.rst:161: ... reader = csv.DictReader(csvfile) I did a quick test ...
5 years, 8 months ago #4
charlax
https://bugs.python.org/review/20351/diff/11072/Doc/library/csv.rst File Doc/library/csv.rst (right): https://bugs.python.org/review/20351/diff/11072/Doc/library/csv.rst#newcode163 Doc/library/csv.rst:163: ... print(row['first_name'], row['last_name'].upper()) Sure! Fixed.
5 years, 8 months ago #5
asvetlov
review http://bugs.python.org/review/20351/diff/11674/Doc/library/csv.rst File Doc/library/csv.rst (right): http://bugs.python.org/review/20351/diff/11674/Doc/library/csv.rst#newcode162 Doc/library/csv.rst:162: A short usage example:: Just use :: http://bugs.python.org/review/20351/diff/11674/Doc/library/csv.rst#newcode195 ...
5 years, 8 months ago #6
charlax
http://bugs.python.org/review/20351/diff/11674/Doc/library/csv.rst File Doc/library/csv.rst (right): http://bugs.python.org/review/20351/diff/11674/Doc/library/csv.rst#newcode162 Doc/library/csv.rst:162: A short usage example:: You mean without `A short ...
5 years, 7 months ago #7
ezio.melotti
5 years, 4 months ago #8
LGTM
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+