Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14651)

#20295: imghdr add openexr support

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by m.vignali
Modified:
5 years, 2 months ago
Reviewers:
berker.peksag
CC:
r.david.murray, SilentGhost, Claudiu.Popa, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, mvignali
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/imghdr.rst View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
Lib/imghdr.py View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
Lib/test/test_imghdr.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
berkerpeksag
5 years, 8 months ago #1
The patch also needs documentation update. You could add the exr format to
Doc/library/imghdr.rst.

It also would be good to add a versionadded directive to the documentation. For
example:

    .. versionadded:: 3.5
       The *exr* format was added.

http://bugs.python.org/review/20295/diff/10624/Lib/imghdr.py
File Lib/imghdr.py (right):

http://bugs.python.org/review/20295/diff/10624/Lib/imghdr.py#newcode115
Lib/imghdr.py:115: def test_exr(h,f):
Please add a space after the ",".

http://bugs.python.org/review/20295/diff/10624/Lib/imghdr.py#newcode116
Lib/imghdr.py:116: if h[0]==0x76 and h[1]==0x2f and h[2]==0x31 and h[3]==0x01:
`h[0]==0x76` is not allowed in PEP 8. Please use `h[0] == 0x76` instead.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+