Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169072)

#20265: Bring Doc/using/windows up to date

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by zachary.ware
Modified:
5 years, 7 months ago
Reviewers:
merwok, kathleen, martin
CC:
Nick Coghlan, ezio.melotti, eric.araujo, jesstess, docs_python.org, anikom15, devnull_psf.upfronthosting.co.za, Zach Ware, ingrid, kathweaver, ssouravsingh12_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 29

Patch Set 3 #

Patch Set 4 #

Total comments: 42

Patch Set 5 #

Patch Set 6 #

Total comments: 36

Patch Set 7 #

Total comments: 8

Patch Set 8 #

Total comments: 10

Patch Set 9 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/faq/windows.rst View 1 2 3 4 5 6 7 8 9 chunks +31 lines, -26 lines 0 comments Download

Messages

Total messages: 9
eric.araujo
Thanks for the patch! http://bugs.python.org/review/20265/diff/11287/Doc/faq/windows.rst File Doc/faq/windows.rst (right): http://bugs.python.org/review/20265/diff/11287/Doc/faq/windows.rst#newcode119 Doc/faq/windows.rst:119: a list of directories where ...
5 years, 9 months ago #1
Zach Ware
A few comments, both style and content. Definite step forward, though! http://bugs.python.org/review/20265/diff/11287/Doc/faq/windows.rst File Doc/faq/windows.rst (right): ...
5 years, 9 months ago #2
Zach Ware
This review turned out a lot longer than I expected it to, but we're moving ...
5 years, 9 months ago #3
kathweaver
I've just uploaded the new patches. http://bugs.python.org/review/20265/diff/11287/Doc/faq/windows.rst File Doc/faq/windows.rst (right): http://bugs.python.org/review/20265/diff/11287/Doc/faq/windows.rst#newcode14 Doc/faq/windows.rst:14: XXX need review ...
5 years, 9 months ago #4
Zach Ware
Here's a review of the latest patch. http://bugs.python.org/review/20265/diff/11340/Doc/faq/windows.rst File Doc/faq/windows.rst (right): http://bugs.python.org/review/20265/diff/11340/Doc/faq/windows.rst#newcode20 Doc/faq/windows.rst:20: The situation ...
5 years, 8 months ago #5
kathweaver
http://bugs.python.org/review/20265/diff/11340/Doc/faq/windows.rst File Doc/faq/windows.rst (right): http://bugs.python.org/review/20265/diff/11340/Doc/faq/windows.rst#newcode20 Doc/faq/windows.rst:20: The situation has been made somewhat simpler since Python ...
5 years, 8 months ago #6
loewis
http://bugs.python.org/review/20265/diff/11405/Doc/using/windows.rst File Doc/using/windows.rst (right): http://bugs.python.org/review/20265/diff/11405/Doc/using/windows.rst#newcode104 Doc/using/windows.rst:104: Python 3.4, the installer has an option to set ...
5 years, 8 months ago #7
kathweaver
I've fixed the minor changes, but am going to wait on the major ones (removing ...
5 years, 8 months ago #8
Zach Ware
5 years, 7 months ago #9
I'm so sorry, I had a review half-finished a month ago, but I never got it
posted.

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst
File Doc/faq/windows.rst (right):

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst#newcode46
Doc/faq/windows.rst:46: Command Prompt followed by (Admin).  You should be able
to recognize when
This isn't good advice, not all users will be able to use the Admin prompt (or
necessarily have it available; I'm not sure about that though).  I've confirmed
that the administrative prompt is not an absolute necessity for using Python on
Windows 8+.

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst#newcode75
Doc/faq/windows.rst:75: Python 3.4.0 (v3.4.0:bd8afb90ebf2, Sep 29 2012,
10:55:48) [MSC v.1600 32 bit (Intel)] on win32
Let's not lie about the revision id :). v3.4.0 is 04f714765c13, with a date and
time of Mar 16 2014, 19:24:06.  Or we can replace the whole revision id with
"default" (a current date would be good, though).

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst#newcode131
Doc/faq/windows.rst:131: like ``C:\Python33``.  Otherwise you will be reduced to
a search of your whole
s/33/34/

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst#newcode134
Doc/faq/windows.rst:134: installed in the ``C:\Python33`` directory (the default
at the time of writing),
s/33/34/

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst#newcode137
Doc/faq/windows.rst:137: c:\Python33\python
s/33/34/

http://bugs.python.org/review/20265/diff/11414/Doc/faq/windows.rst#newcode213
Doc/faq/windows.rst:213: number such as "33" for Python 3.4.
"33" should be "34"

http://bugs.python.org/review/20265/diff/11414/Doc/using/windows.rst
File Doc/using/windows.rst (right):

http://bugs.python.org/review/20265/diff/11414/Doc/using/windows.rst#newcode85
Doc/using/windows.rst:85: * Select Python through File Explorer
Is "File Explorer" what "Windows Explorer" is called in Win8?  Also, how does
this differ from "Find the Python directory and double click python"?

http://bugs.python.org/review/20265/diff/11414/Doc/using/windows.rst#newcode113
Doc/using/windows.rst:113: installer to choose it.  The alternative is manually
modifying the :envvar:`%PATH%`.  See the
Long line.

http://bugs.python.org/review/20265/diff/11414/Doc/using/windows.rst#newcode188
Doc/using/windows.rst:188: administrative rights):
Nix this parenthetical

http://bugs.python.org/review/20265/diff/11414/Doc/using/windows.rst#newcode190
Doc/using/windows.rst:190: #. Launch a command prompt with administrator rights.
s/administrator/administrative/
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+