Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89433)

#20226: Argument Clinic: support for simple expressions?

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by georg
Modified:
5 years, 7 months ago
Reviewers:
zachary.ware, larry
CC:
Georg, larry, meadori, devnull_psf.upfronthosting.co.za, Zach Ware, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 8

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/arg.rst View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
Doc/howto/clinic.rst View 1 2 4 chunks +129 lines, -28 lines 2 comments Download
Lib/inspect.py View 1 2 2 chunks +54 lines, -33 lines 0 comments Download
Lib/test/test_inspect.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
Modules/_cursesmodule.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
Modules/_dbmmodule.c View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
Modules/_opcode.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
Modules/posixmodule.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
Modules/_testcapimodule.c View 1 2 2 chunks +3 lines, -1 line 0 comments Download
Modules/zlibmodule.c View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
Tools/clinic/clinic.py View 1 2 21 chunks +163 lines, -83 lines 1 comment Download
Tools/clinic/clinic_test.py View 1 2 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 6
Zach Ware
http://bugs.python.org/review/20226/diff/10575/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/20226/diff/10575/Lib/inspect.py#newcode2026 Lib/inspect.py:2026: def p(name_node, default_node, default=object()): Found it. default should be ...
5 years, 7 months ago #1
Georg
http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py File Tools/clinic/clinic.py (right): http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py#newcode2534 Tools/clinic/clinic.py:2534: visit_Ellipsis = bad_node why is poor Ellipsis bad? http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py#newcode2536 ...
5 years, 7 months ago #2
larry
Patch inbound! http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py File Tools/clinic/clinic.py (right): http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py#newcode2534 Tools/clinic/clinic.py:2534: visit_Ellipsis = bad_node On 2014/01/16 10:30:48, Georg ...
5 years, 7 months ago #3
Georg
http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py File Tools/clinic/clinic.py (right): http://bugs.python.org/review/20226/diff/10575/Tools/clinic/clinic.py#newcode2536 Tools/clinic/clinic.py:2536: # "starred": "a = [1, 2, 3]; *a" On ...
5 years, 7 months ago #4
Georg
Looks good. http://bugs.python.org/review/20226/diff/10597/Doc/howto/clinic.rst File Doc/howto/clinic.rst (right): http://bugs.python.org/review/20226/diff/10597/Doc/howto/clinic.rst#newcode705 Doc/howto/clinic.rst:705: A string containing a list of Python ...
5 years, 7 months ago #5
larry
5 years, 7 months ago #6
Done, with some bonus fixes.

http://bugs.python.org/review/20226/diff/10597/Doc/howto/clinic.rst
File Doc/howto/clinic.rst (right):

http://bugs.python.org/review/20226/diff/10597/Doc/howto/clinic.rst#newcode705
Doc/howto/clinic.rst:705: A string containing a list of Python types (and
possibly pseudo-types);
On 2014/01/16 18:31:25, Georg wrote:
> For object(converter=...), isn't "type" the C type?

Whoops!  Yes, this should be "types", not "type".  Done.

Also, in search-and-replacing for this, I discovered that the 'y' and 'y#'
legacy converters were specifying 'type', not 'types'.  I guess nobody is using
them!
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+